Merged
Conversation
Collaborator
|
Looks great Manuel! In response to your questions:
|
wkim10
approved these changes
Apr 17, 2025
Collaborator
wkim10
left a comment
There was a problem hiding this comment.
Thanks Manuel looks great overall! Only thing left is to just refactor the events page with the time slot component like you mentioned, after that's done feel free to merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added frontend for the admin modify time flow.
Issues
#87
Screenshots
Test
Only front end still need to add logic for backend and error checking
Possible Downsides
For the calendar, I used DatePicker from MUI. Should we allow the calendar to pop out or no, the figma does not show it but I am not sure.
I also made the time slots into a component, which I got from the event page on the volunteer page.
. Let me know if you want me to refactor the event page to use that component, it should be pretty straight forward it only handles logic for selecting time.
I also noticed that the ticket for Group Sign Up flow, uses the calendar and time slots, should we make those into components and use them for both tickets? Or is it different for each one?
Additional Documentations