fix: render text inside containers with mixed-case fractional indices#24
Merged
fix: render text inside containers with mixed-case fractional indices#24
Conversation
localeCompare() sorts uppercase after lowercase in many locales, reversing the intended z-order of Excalidraw's fractional indices. This caused text inside containers to render behind the container's filled background, making it invisible. Replace with simple < / > comparison, matching the original Excalidraw's orderByFractionalIndex() implementation.
Generated via Docker for the new contained-text fixture that verifies text renders inside filled containers with mixed-case fractional indices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localeCompare()sorts uppercase after lowercase in many locales, reversing the intended order of Excalidraw's fractional indices (e.g., container"b1QV"sorted after text"b1Ql", drawing the filled container on top of the text)</>ASCII comparison, matching the original Excalidraw'sorderByFractionalIndex()Test plan