Open
Conversation
a8cf017 to
a8cdc0f
Compare
Closed
Added performance tests to compare it against the C implementation
1. Streaming Read/Write: The implementation no longer loads the entire ZIP file or its entries into memory. It now uses a DataSource system to defer data access until the final write operation. 2. Random Access Seeking: I implemented platform-specific random-access seeking (openSourceAt) for JVM (using RandomAccessFile) and Native (using fseek). This eliminated the $O(N^2)$ overhead caused by Source.skip, which previously read and discarded data from the start of the file for every entry. 3. Optimized CRC32: Replaced the naive bit-by-bit CRC32 with a high-performance table-based implementation.
01d1d3c to
be4ec18
Compare
be4ec18 to
125cf61
Compare
Contributor
Author
|
separated this from the other PRs, no longer includes iOS or test stuff |
|
Any progress here? It would be awesome :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I thought I'd try, just for fun, and possibly to support WASM targets, converting the C implementation, to pure Kotlin.
Obviously it would be slower, but it would be maximally compatible and simple!
So I did it, and then implemented some performance tests to see just how much slower it would be.
Well it turns out, it's still pretty good. This is using the Kompress KMP lib for the Deflate implementation.
Here are the performance results:

It's about 15% slower, but it's pure KMP, could run on WASM even. So that's pretty neat.