Conversation
Updated to the latest headers fronm kuba
- Converted the C test suite from Kuba Zip to Kotlin - Switched the JVM implementation to zip4j because the built in JVM implementation packed Append functionality. This allowed the JVM impl to pass the whole test suite
Added performance tests to compare it against the C implementation
1. Streaming Read/Write: The implementation no longer loads the entire ZIP file or its entries into memory. It now uses a DataSource system to defer data access until the final write operation. 2. Random Access Seeking: I implemented platform-specific random-access seeking (openSourceAt) for JVM (using RandomAccessFile) and Native (using fseek). This eliminated the $O(N^2)$ overhead caused by Source.skip, which previously read and discarded data from the start of the file for every entry. 3. Optimized CRC32: Replaced the naive bit-by-bit CRC32 with a high-performance table-based implementation.
Only Kotlin now
Wavesonics
force-pushed
the
only-kotlin
branch
from
f62b4b1 to
d065861
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay I realize this is a lot of PRs, but you can choose your own adventure here, they all stack on each other: