Conversation
Updated to the latest headers fronm kuba
|
Okay, I added the |
|
Hi @Wavesonics, thank you for the PR! What were your build steps of kuba zip for the different targets? Do they differ from the ones described in #2 (comment)? I know that kzip currently does not provideany tests, which is still something that needs to be added. How did you test whether the new targets behave as expected?
Yeah, integration of the kuba zip build into the gradle setup is definitley something that is needed. |
|
Check out #5, I brought over the test suite from Kuba Zip to verify the iOS implementation |
|
will have to dig through my stuff from yesterday, but it probably won't be today |
|
What were your build steps of kuba zip for the different targets? |
I added the iOS KMP targets here for issue #1
I had to compile the new libs for the cinterop, so I grabbed the latest .c from here:
https://github.com/kuba--/zip
Which also required me to grab their latest headers. Should be fine? But maybe it'd be worth recompiling all of the platforms from the latest kuba/zip?
On second thought, it's a simple .c file, you could include it in the repository, and gradle or CI could build the artifats as part of this project, idk. Just spitballing.