Skip to content

Comments

Add Ios support#3

Open
Wavesonics wants to merge 3 commits intoJojo4GH:masterfrom
Wavesonics:ios-support
Open

Add Ios support#3
Wavesonics wants to merge 3 commits intoJojo4GH:masterfrom
Wavesonics:ios-support

Conversation

@Wavesonics
Copy link
Contributor

I added the iOS KMP targets here for issue #1

I had to compile the new libs for the cinterop, so I grabbed the latest .c from here:
https://github.com/kuba--/zip

Which also required me to grab their latest headers. Should be fine? But maybe it'd be worth recompiling all of the platforms from the latest kuba/zip?

On second thought, it's a simple .c file, you could include it in the repository, and gradle or CI could build the artifats as part of this project, idk. Just spitballing.

@Wavesonics
Copy link
Contributor Author

Okay, I added the zip.c file, so any recompiling of artifacts is sure to use the exact same version

@Jojo4GH
Copy link
Owner

Jojo4GH commented Dec 28, 2025

Hi @Wavesonics, thank you for the PR!

What were your build steps of kuba zip for the different targets? Do they differ from the ones described in #2 (comment)?

I know that kzip currently does not provideany tests, which is still something that needs to be added. How did you test whether the new targets behave as expected?

On second thought, it's a simple .c file, you could include it in the repository, and gradle or CI could build the artifats as part of this project, idk. Just spitballing.

Yeah, integration of the kuba zip build into the gradle setup is definitley something that is needed.
Then we can use GitHubs macos runners and do not have to rely on contributors with macs.

@Wavesonics
Copy link
Contributor Author

Check out #5, I brought over the test suite from Kuba Zip to verify the iOS implementation

This was referenced Dec 28, 2025
@Wavesonics
Copy link
Contributor Author

will have to dig through my stuff from yesterday, but it probably won't be today

@Jojo4GH
Copy link
Owner

Jojo4GH commented Jan 4, 2026

What were your build steps of kuba zip for the different targets?
Do they differ from the ones described in #2 (comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants