install, docker: --with-matplotlib

[3nprob]

• install.sh: Add --with-matplotlib flag to also install matplotlib for graph support
• docker: install matplotlib if build-arg WITH_MATPLOTLIB=1
• pin matplotlib like other python dependencies

[roshii]

nACK: afaict matplotlib is nor a project dependency, nor used in any dev flow

[3nprob]

nACK: afaict matplotlib is nor a project dependency, nor used in any dev flow

It's used by ob-watcher to plot graphs. Without it you get an error telling you to please install matplotlib when navigating to some views.

https://github.com/JoinMarket-Org/joinmarket-clientserver/blame/5246c1ccb5fcc9eae383e8addcca3677bb9e76c8/scripts/obwatch/ob-watcher.py#L32-L36

https://github.com/JoinMarket-Org/joinmarket-clientserver/blame/5246c1ccb5fcc9eae383e8addcca3677bb9e76c8/scripts/obwatch/ob-watcher.py#L259C13-L260

joinmarket-webui/jam#182

So "user flow" more than "dev flow" - it's already an undocumented optional runtime dependency.

[roshii]

I missed that usage, but remain concern by adding matplotlib to project dependencies, which it is not one per se, and it's an heavy one.

I'd suggest wrapping ob-watcher into a shell script, which is also arguable provided the ob-watcher handles missing matplotlib gracefully, and can be resolved by a single pip install.

nACK

[3nprob]

@roshii

Note that here matplotlib is still not installed by default for non-docker invocations and requires passing --with-matplotlib flag to install.sh for it to be installed.

I'd suggest wrapping ob-watcher into a shell script, which is also arguable provided the ob-watcher handles missing matplotlib gracefully, and can be resolved by a single pip install.

I think downloading and installing libraries dynamically at runtime is an antipattern and should be avoided for a myriad of reasons. "Can be resolved by a single pip install" is not as trivial for docker users.

For docker, I see a 30% image size increase with this PR vs master.

(So if coupled with #1800 we are still net-negative ;))

[roshii]

here's how i'd tackle it: roshii#6

Missing a little configuration step to get it running out of the box

[3nprob]

Update: matplotlib is now opt-in for docker too.

Enable with --build-arg WITH_MATPLOTLIB=1

[roshii]

while this is better, i am not in favor of this approach. let's not add non direct project dependencies, even conditionally.