Skip to content

Forward refs correctly in ButtonWrapper and align with UI component patterns #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ragsav wants to merge 1 commit into
base: postgres
Choose a base branch
from
Open

Forward refs correctly in ButtonWrapper and align with UI component patterns #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions apps/frontend/src/presentation/components/ui/button.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,23 @@
import React, { useState } from "react";
import React from "react";
import PropTypes from "prop-types";
import { Button as AntButton } from "antd";

// Bug fix: ButtonWrapper now forwards refs correctly
export const Button = React.forwardRef((props, ref) => {
return <AntButton htmlType="button" ref={ref} style={{ boxShadow: 'none' }} {...props} />;
const Button = React.forwardRef(({ style, ...props }, ref) => {
return (
<AntButton
htmlType="button"
ref={ref}
style={{ boxShadow: "none", ...style }}
{...props}
/>
);
});

Button.displayName = "Button";

Button.propTypes = {
style: PropTypes.object,
};

export { Button };