forked from cho-log/spring-learning-test
-
Notifications
You must be signed in to change notification settings - Fork 5
[spring-core-2] haon.lee(이민성) 미션 제출합니다. #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msung99
wants to merge
5
commits into
Japring-Study:haon/spring-core-2
Choose a base branch
from
msung99:haon/spring-core-2
base: haon/spring-core-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−3
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4539607
feat: Declaring a Bean 기능 구현
msung99 e7af6a0
feat: Bean Dependencies 기능 구현
msung99 defae4d
feat: Using @PropertySource and @Value 기능 구현
msung99 eb8eb5a
feat: Externalized Configuration 기능 구현
msung99 0967ba9
feat: @Profile 기능 구현
msung99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 8 additions & 2 deletions
10
spring-core-2/initial/src/main/java/cholog/property/config/AuthConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,17 @@ | ||
| package cholog.property.config; | ||
|
|
||
| import cholog.property.JwtTokenKeyProvider; | ||
| import org.springframework.beans.factory.annotation.Value; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| // TODO: Java-based Configuration을 하기 위한 클래스로 지정하기 | ||
| @Configuration | ||
| public class AuthConfig { | ||
| // TODO: application.properties의 security.jwt.token.secret-key 값을 활용하여 JwtTokenKeyProvider를 빈으로 등록하기 | ||
| public JwtTokenKeyProvider jwtTokenKeyProvider() { | ||
| return new JwtTokenKeyProvider(""); | ||
| @Bean | ||
| public JwtTokenKeyProvider jwtTokenKeyProvider(@Value("${security.jwt.token.secret-key}") String secretKey) { | ||
| return new JwtTokenKeyProvider(secretKey); | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,10 +2,15 @@ | |
|
|
||
| import cholog.property.GoogleDriveRestClient; | ||
| import cholog.property.GoogleMapsRestClient; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
| import org.springframework.context.annotation.PropertySource; | ||
| import org.springframework.core.env.Environment; | ||
|
|
||
| // TODO: Java-based Configuration을 하기 위한 클래스로 지정하기 | ||
| // TODO: ext-api.properties 파일을 활용하기 위한 설정 추가하기 | ||
| @Configuration | ||
| @PropertySource("classpath:ext-api.properties") | ||
| public class PropertySourceConfig { | ||
|
|
||
| private final Environment env; | ||
|
|
@@ -16,8 +21,9 @@ public PropertySourceConfig(Environment env) { | |
|
|
||
| // TODO: ext-api.properties의 google.api.endpoint 값을 Environment를 사용해서 가져오기 | ||
| // TODO: 위 endpoint 값을 사용하여 GoogleMapsRestClient를 빈으로 등록하기 | ||
| @Bean | ||
| public GoogleMapsRestClient googleMapsRestClient() { | ||
| return new GoogleMapsRestClient(""); | ||
| return new GoogleMapsRestClient(env.getProperty("google.api.endpoint")); | ||
| } | ||
|
|
||
| // TODO: ext-api.properties의 google.api.endpoint 값을 어노테이션을 사용해서 가져오기 | ||
|
Comment on lines
+24
to
29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 해당 코드 아랫부분은 아직 구현이 안된 것 같습니다 |
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 경우가 테스트가 통과되나요?
return값이
AuthService객체이길 기대하는데 null을 반환해도 되는지가 의아해서 여쭤봅니다There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 이건 지난 미션 관련 내용인데, 실수로 같이 올라가서 그런가 봅니다..! 이전 미션 수행시에는 작성했어요!!