[spring-core-2] haon.lee(이민성) 미션 제출합니다. #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swandevson
reviewed
Aug 15, 2024
Comment on lines
+13
to
22
| @Bean | ||
| public AuthService authService() { | ||
| return null; | ||
| } | ||
|
|
||
| // TODO: AuthenticationPrincipalArgumentResolver를 빈 등록하고 authService에 대한 의존성을 주입하기 | ||
| @Bean | ||
| public AuthenticationPrincipalArgumentResolver authenticationPrincipalArgumentResolver() { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
해당 경우가 테스트가 통과되나요?
return값이 AuthService 객체이길 기대하는데 null을 반환해도 되는지가 의아해서 여쭤봅니다
Author
There was a problem hiding this comment.
아 이건 지난 미션 관련 내용인데, 실수로 같이 올라가서 그런가 봅니다..! 이전 미션 수행시에는 작성했어요!!
Comment on lines
+24
to
29
| @Bean | ||
| public GoogleMapsRestClient googleMapsRestClient() { | ||
| return new GoogleMapsRestClient(""); | ||
| return new GoogleMapsRestClient(env.getProperty("google.api.endpoint")); | ||
| } | ||
|
|
||
| // TODO: ext-api.properties의 google.api.endpoint 값을 어노테이션을 사용해서 가져오기 |
|
고생하셨습니다!! 마지막 즈음 끊긴 부분이 있는것 같은데 확인해주시면 감사하겠습니다!! |
dayaelee
reviewed
Aug 19, 2024
Member
dayaelee
left a comment
dayaelee
left a comment
There was a problem hiding this comment.
목적에 맞게 코드 잘 작성하신 것 같습니다! 고생하셨습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
하온 spring core 미션 제출합니다 🙂