Skip to content

fix(content-guards): set correct per-repo limits (100 issues, 15 PRs) #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobPEvans merged 3 commits into from
Mar 17, 2026
+17 −8
Merged

fix(content-guards): set correct per-repo limits (100 issues, 15 PRs) #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cae9e2
fix(content-guards): raise issue hard limit from 50 to 150 per repo
JacobPEvans Mar 17, 2026
c5dda34
fix(content-guards): set correct per-repo limits (100 issues, 15 PRs)
JacobPEvans Mar 17, 2026
ba7f0bc
fix: cap PR ai-created sublimit at 15 and update tests
JacobPEvans Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions content-guards/scripts/enforce-issue-limits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
Uses `--author @me` for identity-based filtering (unforgeable).

Hard limits (per-repo):
- 50 total open issues/PRs
- 100 total open issues
- 15 total open PRs
- 25 AI-created open issues/PRs (labeled "ai-created")

Rate limits (24h rolling window):
Expand All @@ -29,7 +30,7 @@
from datetime import datetime, timedelta, timezone

# Hard limits: (total_open, ai_created_open) per resource type
HARD_LIMITS = {"issue": (50, 25), "pr": (50, 25)}
HARD_LIMITS = {"issue": (100, 25), "pr": (15, 15)}

# 24h rolling rate limit per resource type
RATE_LIMIT_24H = 25
Expand Down
20 changes: 14 additions & 6 deletions tests/content-guards/enforce-issue-limits/enforce-issue-limits.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,15 @@ setup() {

# Write a configurable fake `gh` script. Tests set GH_RESPONSE and
# GH_EXIT_CODE before calling the script under test.
# GH_RESPONSE_ALL overrides the response when --state all is present
# (used to simulate different open vs all-state counts for rate limit tests).
cat > "$FAKE_GH_DIR/gh" <<'EOF'
#!/usr/bin/env bash
echo "${GH_RESPONSE:-[]}"
if [[ -n "${GH_RESPONSE_ALL:-}" ]] && [[ "$*" == *"--state all"* ]]; then
echo "$GH_RESPONSE_ALL"
else
echo "${GH_RESPONSE:-[]}"
fi
exit "${GH_EXIT_CODE:-0}"
EOF
chmod +x "$FAKE_GH_DIR/gh"
Expand Down Expand Up @@ -89,13 +95,13 @@ run_hook() {
# TC3: gh issue create - total issue hard limit (exit 2)
# ---------------------------------------------------------------------------

@test "TC3: gh issue create blocked when total open issues >= 50" {
export GH_RESPONSE="$(build_json_array '{"number":__N__,"labels":[]}' 50)"
@test "TC3: gh issue create blocked when total open issues >= 100" {
export GH_RESPONSE="$(build_json_array '{"number":__N__,"labels":[]}' 100)"

run_hook '{"tool_input":{"command":"gh issue create --title test"}}'
[ "$status" -eq 2 ]
[[ "$output" =~ "BLOCKED: Issue creation limit exceeded" ]]
[[ "$output" =~ "50/50" ]]
[[ "$output" =~ "100/100" ]]
}

# ---------------------------------------------------------------------------
Expand Down Expand Up @@ -133,7 +139,9 @@ run_hook() {
@test "TC6: gh pr create blocked when 25 PRs created in last 24h" {
local now
now="$(utc_now)"
export GH_RESPONSE="$(build_json_array '{"createdAt":"'"$now"'"}' 25)"
# Open PRs under hard limit (14 < 15), but 25 total created in 24h (rate limit)
export GH_RESPONSE="$(build_json_array '{"number":__N__,"labels":[],"createdAt":"'"$now"'"}' 14)"
export GH_RESPONSE_ALL="$(build_json_array '{"createdAt":"'"$now"'"}' 25)"

run_hook '{"tool_input":{"command":"gh pr create --title test"}}'
[ "$status" -eq 2 ]
Expand Down Expand Up @@ -194,7 +202,7 @@ run_hook() {
# ---------------------------------------------------------------------------

@test "TC10: hard-limit block message does not reference missing skill path" {
export GH_RESPONSE="$(build_json_array '{"number":__N__,"labels":[]}' 50)"
export GH_RESPONSE="$(build_json_array '{"number":__N__,"labels":[]}' 100)"

run_hook '{"tool_input":{"command":"gh issue create --title test"}}'
[ "$status" -eq 2 ]
Expand Down
Loading