fix(content-guards): set correct per-repo limits (100 issues, 15 PRs)#134
fix(content-guards): set correct per-repo limits (100 issues, 15 PRs)#134JacobPEvans merged 3 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses the need to accommodate a higher volume of open issues and pull requests by raising the per-repository hard limit. The change primarily updates a configuration value and its corresponding documentation, allowing for increased activity without hitting artificial caps, particularly relevant for automated content generation workflows. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly increases the hard limit for open issues and pull requests from 50 to 150 in the script and its docstring. However, the automated tests that verify this limit have not been updated, which will cause the build to fail. I've provided a comment on the relevant line with details on which tests to update. I also included a suggestion to refactor the hardcoded limits into named constants to improve code clarity and maintainability.
There was a problem hiding this comment.
Pull request overview
This PR updates the content-guards issue/PR creation limiter to allow more open work items per repository by increasing the configured hard limit.
Changes:
- Updated the documented hard limit from 50 to 150 total open issues/PRs.
- Increased
HARD_LIMITSfor both issues and PRs from 50 to 150.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Previous PR raised both to 150 which was too high. Correct limits: - Issues: 100 total open per repo (up from 50) - PRs: 15 total open per repo (down from 50) - AI-created: 25 each (unchanged) (claude)
- AI-created sublimit for PRs was 25 but total PR limit is 15, making the sublimit unreachable dead code. Capped at 15. - Updated TC3/TC10 from 50 to 100 for new issue hard limit - Enhanced fake gh to support GH_RESPONSE_ALL for --state all queries - Updated TC6 to test rate limit independently of hard limit (claude)
…ery limit, clarify docs (claude)
PR #134: Raise Issue and PR Hard Limits
Summary
Corrects hard limits for issue and PR creation enforcement in
enforce-issue-limits.py:Also updates test coverage to verify new limits and improves fake
ghmock to support state-aware responses (--state allfor rate-limit testing).Changes
enforce-issue-limits.py:
HARD_LIMITS = {"issue": (100, 25), "pr": (15, 15)}enforce-issue-limits.bats:
ghto support state-aware responses viaGH_RESPONSE_ALLvariable (lines 25–26)ghto distinguish open (14) vs. all-state (25) countsTest Plan
HARD_LIMITSdict uses correct valuesbats tests/content-guards/enforce-issue-limits/enforce-issue-limits.bats— all 19 tests passghmock🤖 Generated with Claude Code