Skip to content

Conversation

@chengdang
Copy link
Contributor

@chengdang chengdang commented Jan 15, 2026

Description

PR for including aerosol backscatter coefficient with GOCART-GEOS5 LUT.

This PR was developed last summer with the support from Sarah for LiDAR DA:

Dependencies

This PR is partially overlapped with #285, and should be merged coordinately.

Impact

None

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

Note

  • To test this PR, I used the most recent version of GOCART-GEOS5 LUT for the following tests, so by defaul these tests will fail.
  • This LUT is not distributed yet, so please link the above mentioned table in testinput folder as CRTMv3/build/test/testinput/AerosolCoeff.GOCART-GEOS5.nc4, and before running the ctests.
  • After this PR review, before the PR merge, I will revert changes to these files and set the input LUTs as default: test/mains/regression/forward/test_AOD/test_AOD.f90, test/mains/regression/k_matrix/test_AOD/test_AOD.f90
94% tests passed, 12 tests failed out of 192

Label Time Summary:
CRTM_Tests    =  88.71 sec*proc (192 tests)

Total Test time (real) =  25.05 sec

The following tests FAILED:
	 28 - test_forward_AOD_cris-fsr_n21 (Failed)            CRTM_Tests
	 29 - test_forward_AOD_v.abi_g18 (Failed)               CRTM_Tests
	 30 - test_forward_AOD_cris399_npp (Failed)             CRTM_Tests
	 31 - test_forward_AOD_v.abi_gr (Failed)                CRTM_Tests
	 32 - test_forward_AOD_abi_g18 (Failed)                 CRTM_Tests
	 33 - test_forward_AOD_airs_aqua (Failed)               CRTM_Tests
	101 - test_k_matrix_AOD_cris-fsr_n21 (Failed)           CRTM_Tests
	102 - test_k_matrix_AOD_v.abi_g18 (Failed)              CRTM_Tests
	103 - test_k_matrix_AOD_cris399_npp (Failed)            CRTM_Tests
	104 - test_k_matrix_AOD_v.abi_gr (Failed)               CRTM_Tests
	105 - test_k_matrix_AOD_abi_g18 (Failed)                CRTM_Tests
	106 - test_k_matrix_AOD_airs_aqua (Failed)              CRTM_Tests

@chengdang chengdang self-assigned this Jan 15, 2026
@BenjaminTJohnson BenjaminTJohnson merged commit 799ad5f into develop Jan 22, 2026
1 of 2 checks passed
@BenjaminTJohnson BenjaminTJohnson deleted the feature/cd_kprof branch January 22, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants