-
Notifications
You must be signed in to change notification settings - Fork 18
Fix Missing Aerosol Scattering Jacobians and Restore Backscatter Logic #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
BenjaminTJohnson
merged 17 commits into
develop
from
feature/btj-aerosol_scatter-jacobian
Jan 22, 2026
Merged
Fix Missing Aerosol Scattering Jacobians and Restore Backscatter Logic #285
BenjaminTJohnson
merged 17 commits into
develop
from
feature/btj-aerosol_scatter-jacobian
Jan 22, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and copy routines. This change ensures that adjoint sensitivities for Relative Humidity, calculated in low-level aerosol routines, are correctly propagated back to the user-facing Atmosphere_K structure.
Added initialization and adjoint summation for aerosol Effective_Variance in the atmosphere layer supplementation routines. This completes the propagation link for aerosol size variance sensitivities.
…j-aerosol_scatter-jacobian
Contributor
|
All ctests pass, and all changes look good. |
Contributor
Author
|
I removed the IF aerosol scheme GEOS5 type lines, it's unnecessarily restrictive. |
…ficient, but if not present, fall back to default GEOS5 coefficient. This will prevent ctest failures until we can get the new backscattering coefficient into the tarball and distributed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses critical gaps in the CRTMv3 Aerosol Scattering module by restoring missing Jacobian calculations for key state variables and re-enabling backscatter coefficient logic that had been inadvertently disabled. These changes ensure that sensitivities for aerosol concentration, relative humidity, and effective radius are correctly propagated through the Tangent Linear (TL), Adjoint (AD), and K-Matrix interfaces.
Key Changes
1. Restored Relative Humidity Jacobians
CRTM_AerosolScatter.f90(Forward, TL, and AD).2. Restored Backscatter & Asymmetry Logic
kb) and Asymmetry_Factor (g) interpolation and accumulation into theASvar_typestructure and aerosol scattering routines.3. Comprehensive Unit Testing
test_AerosolScatter_TL.f90to verify non-zero sensitivities for relative humidity and aerosol concentration using MODIS (visible/IR) channels instead of ATMS (microwave), which bypasses aerosol scattering.test_AerosolScatter_AD.f90to validate TL/AD consistency via the dot-product test (passes to machine precision).test_AerosolScatter_K.f90to confirm correct propagation of sensitivities to the top-levelAtmosphere_Kstructure.Validation
Impact
This fix is mandatory for assimilation and retrieval applications involving aerosols where humidity dependence or backscatter (active sensors) is relevant. Without these corrections, the model assumes zero sensitivity to key aerosol properties, leading to incorrect gradients and potential convergence failures in variational (e.g., 4D-Var) systems.