Json format for fsm thresholds #69
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redindelible
previously requested changes
Feb 1, 2025
Contributor
redindelible
left a comment
redindelible
left a comment
There was a problem hiding this comment.
Why are we loading JSON at runtime instead of just baking it into the .elf
redindelible
previously requested changes
Feb 1, 2025
Contributor
redindelible
left a comment
redindelible
left a comment
There was a problem hiding this comment.
Name "sg1-4.h" more clearly. Instead of deleting possibly redundant comments wholesale, try to improve them. Now that we have the chance adding units to the comments in the thresholds files would be appreciated.
Aadityavoru
dismissed
redindelible’s stale review
Fixed the structrure to be more readable and clean, added units as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.