Modify DTO sent to CreateCollection and UpdateCollection use cases

[g-saracca]

What this PR does / why we need it:

Modifies how we are sending the DTO while creating or updating a collection

Which issue(s) this PR closes:

• Closes Modify DTO sent to CreateCollection and UpdateCollection use cases - SPA frontend #593

Suggestions on how to test this:

Step 1: Run the Development Environment

1. Execute npm i.
2. Navigate with cd packages/design-system && npm i && npm run build.
3. Return with cd ../../.
4. Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
5. Navigate with cd dev-env.
6. Start the environment using ./run-env.sh unstable.
7. To verify the environment, visit http://localhost:8000 and check your local Dataverse installation.

Step 2: Test the feature
In the SPA, edit the root collection, change any field, everything should be updated correctly.
Smoke test creating and updating sub collections could be nice also.

[coveralls]

coverage: 97.499% (+0.02%) from 97.481%
when pulling 3b83fb3 on modify-dto-create-update-collection
into 692283b on develop.

[g-saracca]

Thanks @ChengShi-1, all changes requested made 👍🏼

[ChengShi-1]

Looks good! approve

[ofahimIQSS]

Hello!

I’m currently testing this PR locally, and as part of my regression testing, I noticed an issue I wanted to bring to your attention.

When editing the Dataverse root collection under General Information, I added an HTML file into the Description field and saved the changes. However, upon reopening the General Information section for editing, I found that the HTML tags were not preserved—the description is displayed as plain text instead.

Could you verify if this is an issue or is this something still pending development?

Screen.Recording.2025-02-07.at.9.45.42.AM.mov

Additionally, if the description is too long, there should be an option to expand/collapse that section on the root homepage. I didn't see it there, same question as above.

[g-saracca]

Hi @ofahimIQSS this is a known issue and is currently happening on beta.
I think this PR from @ChengShi-1 will fix it.
@ChengShi-1 can you confirm?

[ChengShi-1]

Hi @ofahimIQSS this is a known issue and is currently happening on beta. I think this PR from @ChengShi-1 will fix it. @ChengShi-1 can you confirm?

Hi German, unfortunately it isn't solved. The issue 588 relate to getDataset(), in dataset page, but this error above, happens collection page. We may need create a separate issue for this error.

[ofahimIQSS]

Another observation during testing this PR:

I am unable to add Featured Items to the root collections [Edit - or any collection] page in my local environment - to reproduce:

1. Go to (http://localhost:8000/spa/collections)
2. Edit > Featured Items
3. Add 10 items, add images, and add descriptions to all then publish.
   Issue: I get undefined message - and I am unable to save

Screen.Recording.2025-02-07.at.10.58.59.AM.mov

[ofahimIQSS]

Regression Testing also uncovered this:
Uploading file to Dataset fails when entering special characters in File Path. I checked JSF and a warning message appears when we have special characters in that field. See screenshot below and video of SPA (i cut the video short, it never finishes uploading the file):

Screen.Recording.2025-02-07.at.11.41.39.AM.mov

[g-saracca]

@ofahimIQSS about Collection description and Upload Files filePath bugs please feel free to open issues for that in the frontend repo, but they are not related to this change.
Related to the featured items bug, could you please show me the response error in the network tab from the browser?

[ofahimIQSS]

Next observation I'm just jotting down on this PR:
Dataverse/Collection Name should have Max allowed chars, limits on the input text box. If we go over 288 Characters, the system throws an error message. This issue exists in the JSF as well, see below:

SPA Error:

Here is the Title I'm using (315 characters):
The Legendary Chronicles of Procrastination: A Heroic Tale of Coffee-Fueled Ambitions, Accidental Naps, Overdue Deadlines, and the Eternal Struggle Between ‘Just One More Episode’ and ‘I Should Really Be Productive’—Now Featuring a Cameo by My Lost Sock, Mysterious Fridge Goblin, and That One Unfinished Project from 2017

[ofahimIQSS]

@ofahimIQSS about Collection description and Upload Files filePath bugs please feel free to open issues for that in the frontend repo, but they are not related to this change.

I will go ahead and raise the bugs - thanks! [EDIT: Here they are: https://github.com//issues/599 & https://github.com//issues/600]

Related to the featured items bug, could you please show me the response error in the network tab from the browser?

[g-saracca]

@ofahimIQSS great! I push a fix for the collection name.
I added a max length validation for that field and affiliation field also of 120 characters, please try it.

Please open an issue for the 403 Request Entity too large error on featured items creation, not sure what could be, working ok on my end.

[ChengShi-1]

Good work, small changes

[g-saracca]

my bad, please @ChengShi-1, check again

[ofahimIQSS]

@ofahimIQSS great! I push a fix for the collection name. I added a max length validation for that field and affiliation field also of 120 characters, please try it.

Awesome, I'll take it for a spin.

Please open an issue for the 403 Request Entity too large error on featured items creation, not sure what could be, working ok on my end.

Done: IQSS/dataverse#11238

[ChengShi-1]

Looks good! length limit works on my end. Approve

[g-saracca]

Increased max length validation for collection name and affiliation fields to 255 characters.

[ofahimIQSS]

Can we get this PR reviewed please - merging is blocked :)

[ChengShi-1]

Good

[g-saracca]

@ofahimIQSS already approved 👍🏼

[pdurbin]

Increased max length validation for collection name and affiliation fields to 255 characters.

Yes, anything over 255 characters results in this error for "name" (and "affiliation" should behave the same):

dev_dataverse> Internal Exception: org.postgresql.util.PSQLException: ERROR: value too long for type character varying(255)

Here's how I tested it:

diff --git a/src/test/java/edu/harvard/iq/dataverse/api/DataversesIT.java b/src/test/java/edu/harvard/iq/dataverse/api/DataversesIT.java
index 825465fcd9..e9f56b642b 100644
--- a/src/test/java/edu/harvard/iq/dataverse/api/DataversesIT.java
+++ b/src/test/java/edu/harvard/iq/dataverse/api/DataversesIT.java
@@ -248,7 +248,7 @@ public class DataversesIT {
         String dataverseAlias = UtilIT.getRandomDvAlias();
         String emailAddressOfFirstDataverseContact = dataverseAlias + "@mailinator.com";
         JsonObjectBuilder jsonToCreateDataverse = Json.createObjectBuilder()
-                .add("name", dataverseAlias)
+                .add("name", "Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Donec quam felis, ultricies nec, pellentesque eu, pretium ridicu")
                 .add("alias", dataverseAlias)

[g-saracca]

@ofahimIQSS , this is ready for QA.

[ofahimIQSS]

changes/fixes verified. Merging PR