Skip to content

Conversation

@martinjankoehler
Copy link
Contributor

@martinjankoehler martinjankoehler commented Sep 2, 2025

  • adds dedicated standalone guard ring cell
  • adds guard ring feature to existing cells
  • add xschem symbol + schematic for ptap/ntap with guard ring added

  • Tests pass
  • Appropriate changes to README are included in PR

@martinjankoehler martinjankoehler changed the title PyCells for Guard ring PyCells for Guard Ring Sep 2, 2025
@martinjankoehler martinjankoehler changed the title PyCells for Guard Ring KLayout PyCells: Guard Ring Sep 2, 2025
@d-m-bailey
Copy link
Contributor

@martinjankoehler the first pull request that I made failed CI with the same error. These are the instructions that I was given.

you need to sign-off your commits. In the future, use git commit -s ... to automatically add your signed-off-by. For now, run git rebase --signoff HEAD~2 to sign-off your existing two commits.

I only had 2 commits. It looks like you might have more that need to be signed.

martinjankoehler and others added 19 commits October 1, 2025 15:00
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
… cell

Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
…nd gap in the middle of the array

Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
@martinjankoehler
Copy link
Contributor Author

martinjankoehler commented Oct 1, 2025

@KrzysztofHerman @sergeiandreyev now Signed off

@d-m-bailey Thanks

@martinjankoehler martinjankoehler mentioned this pull request Oct 2, 2025
Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
@KrzysztofHerman
Copy link
Contributor

@martinjankoehler

Thank you for this contribution. I have not been testing yet the LVS of the cells wit the instantiated guard ring so I will ask directly if the symbols for xschem generate a valid netlist entries to be compared with the extracted ptap1/ntap1 devices. I guess the devices with guard ring are recognized during LVS extraction as device + ptap1/ntap1 respectively.

Signed-off-by: Martin Jan Köhler <info@martinjankoehler.com>
@martinjankoehler
Copy link
Contributor Author

@martinjankoehler

Thank you for this contribution. I have not been testing yet the LVS of the cells wit the instantiated guard ring so I will ask directly if the symbols for xschem generate a valid netlist entries to be compared with the extracted ptap1/ntap1 devices. I guess the devices with guard ring are recognized during LVS extraction as device + ptap1/ntap1 respectively.

Yes, @p-fath successfully tested LVS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants