feat(MPU): Remove MPUManager from Runes and add tests for MPU #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgesg82
previously requested changes
Jan 22, 2026
Contributor
jorgesg82
left a comment
jorgesg82
left a comment
There was a problem hiding this comment.
Would it be feasible to convert those tests in GTest ones, and hook them to the CMake test validation flow?
Contributor
Author
The MPU uses the Linker Script as source of truth when placing buffers, so I'm not sure if it is possible to emulate that in gtest, I don't know much about it though, I'll look into it |
victor-Lopez25
approved these changes
Jan 23, 2026
Cantonplas
approved these changes
Jan 23, 2026
FoniksFox
dismissed
jorgesg82’s stale review
Will do in a later pr, it is important to merge this quickly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples / Tests are run by defining the desired example and Test number in main.cpp