Skip to content

ansible-cmdb: build with virtualenv#216121

Merged
Moisan merged 1 commit intomasterfrom
ansible-cmdb_virtualenv
Apr 2, 2025
Merged

ansible-cmdb: build with virtualenv#216121
Moisan merged 1 commit intomasterfrom
ansible-cmdb_virtualenv

Conversation

@Moisan
Copy link
Copy Markdown
Member

@Moisan Moisan commented Mar 23, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

brew test ansible-cmdb currently fails since it depends on python. I tried add a dependency on python but the vendored python packages seem too old for all python versions we support.

Building the archive release with virtualenv is the only way I found to make it work.

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Mar 23, 2025
@Moisan Moisan force-pushed the ansible-cmdb_virtualenv branch 2 times, most recently from 08e1ed5 to 8c8bc92 Compare March 23, 2025 20:44
@Moisan Moisan force-pushed the ansible-cmdb_virtualenv branch from 8c8bc92 to 95c38b7 Compare March 24, 2025 16:30
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Mar 25, 2025
@Moisan Moisan force-pushed the ansible-cmdb_virtualenv branch from 33389b1 to a6b6895 Compare March 25, 2025 19:08
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Mar 25, 2025
@Moisan Moisan added this pull request to the merge queue Apr 2, 2025
Merged via the queue into master with commit 5d67e11 Apr 2, 2025
24 checks passed
@Moisan Moisan deleted the ansible-cmdb_virtualenv branch April 2, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Python use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants