Merged
Conversation
chenrui333
reviewed
Mar 23, 2025
08e1ed5 to
8c8bc92
Compare
daeho-ro
reviewed
Mar 24, 2025
daeho-ro
approved these changes
Mar 24, 2025
8c8bc92 to
95c38b7
Compare
daeho-ro
approved these changes
Mar 25, 2025
carlocab
reviewed
Mar 25, 2025
33389b1 to
a6b6895
Compare
daeho-ro
approved these changes
Mar 26, 2025
carlocab
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?brew test ansible-cmdbcurrently fails since it depends on python. I tried add a dependency on python but the vendored python packages seem too old for all python versions we support.Building the archive release with virtualenv is the only way I found to make it work.