Skip to content

Comments

Fix lambdapi output by updating it with the new printer system#67

Open
jrosain wants to merge 19 commits intoGoelandProver:masterfrom
jrosain:fix-lp-output
Open

Fix lambdapi output by updating it with the new printer system#67
jrosain wants to merge 19 commits intoGoelandProver:masterfrom
jrosain:fix-lp-output

Conversation

@jrosain
Copy link
Member

@jrosain jrosain commented Oct 8, 2025

Bug fix

This PR fixes the lambdapi output that has been broken for a while.

Description

We use the newly introduced Printer system to fix the lambdapi output. Moreover, instead of outputing one big lambda-term, we now output lambdapi proofs in the tactic language, making the output more concise and enabling debugging problems in the output.

I've also updated the CONTRIBUTING instructions with the test-suite stuff.

PR dependencies

Test-suite update

No new test file, but I've updated the test-suite script to check the proofs with lambdapi. As equality is not yet implemented, we also add a lp_tolerate_fail variable that regroups all test-suite files with equality reasoning. As we use the nix shell file, an update of the CI script to include lambdapi shouldn't be necessary.

@jrosain jrosain requested a review from jcailler October 8, 2025 08:13
@github-actions github-actions bot added the needs:ci Needs a CI run before merging label Oct 8, 2025
@jrosain jrosain added kind:cleanup Refactoring or improvement of existing code kind:fix The PR fixes a bug has:other-pr-dependency This PR cannot be merged before another PR (the maintainer should specify the dependency(ies)) part:lambdapi-output request:ci Requests a CI run from the workflow and removed needs:ci Needs a CI run before merging labels Oct 8, 2025
@github-actions github-actions bot removed the request:ci Requests a CI run from the workflow label Oct 8, 2025
@jrosain jrosain changed the title Update lambdapi output with the new system Fix lambdapi output by updating it with the new printer system Oct 8, 2025
@github-actions github-actions bot added the needs:ci Needs a CI run before merging label Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has:other-pr-dependency This PR cannot be merged before another PR (the maintainer should specify the dependency(ies)) kind:cleanup Refactoring or improvement of existing code kind:fix The PR fixes a bug needs:ci Needs a CI run before merging part:lambdapi-output

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants