Add IProof interface with a tree structure and add relevant adapter for []Search.ProofStruct#64
Open
jrosain wants to merge 20 commits intoGoelandProver:masterfrom
Open
Add IProof interface with a tree structure and add relevant adapter for []Search.ProofStruct#64jrosain wants to merge 20 commits intoGoelandProver:masterfrom
IProof interface with a tree structure and add relevant adapter for []Search.ProofStruct#64jrosain wants to merge 20 commits intoGoelandProver:masterfrom
Conversation
jrosain
added
kind:cleanup
github-actions
bot
removed
needs:ci
jrosain
added
kind:enhancement
jrosain
force-pushed
the
add-proof-adapter
branch
from
944ebad to
9f1242c
Compare
jrosain
commented
Jan 29, 2026
Comment on lines
+261
to
+265
| switch f := form.(type) { | ||
| case AST.All: | ||
| return f.GetForm() | ||
| case AST.Ex: | ||
| return f.GetForm() |
Member
Author
There was a problem hiding this comment.
This is wrong, it makes the assumption that there are no nested AST.All / AST.Ex, which isn't always the case.
* non destructive search **does not** manage typed search, only destructive search does * dmt might be incompatible with typed search
…roofs with Goeland
…ial instructions for lambdapi)
jrosain
force-pushed
the
add-proof-adapter
branch
from
9f1242c to
85f405e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a tableaux-like proof interface which all proof structures should implement. Added an adapter to
[]Search.ProofStructas an example. This interface makes a proof have a tree structure, with all the relevant informations on a node: the rule and the kind of rule, the formula on which the rule is applied on, the resulting formulas, the possible formula it has been rewritten with, the possible term generated and the children proofs.I plan to make
type GS3Proof *GS3SequentimplementIProofin the near future.This PR should make it easy to communicate between the different proof structures if needed.
PR dependencies