-
Notifications
You must be signed in to change notification settings - Fork 79
Added Centauro to example-robot-data robots #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
nim65s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thanks for this contribution :)
Please add robots/centauro_description/README.md with a source for these files and their license.
And also a unit test.
cmastalli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @AndrePatri!
It would be nice to include colour information.
for more information, see https://pre-commit.ci
|
@cmastalli, @nim65s, I've added the README.md following the scheme of the other robots and the unit test for nq and nv. As for what concerns the licence, currently the original repo from which I made my fork has no license file, even if it's public. So for now I've put no license. I'll ask people in my research line to add one. As for the colors, I'll try to do it, but I can't guarantee it will happen soon. |
|
I am happy to proceed merging this PR without the colour changes. We can always fix them later. |
|
I'm afraid we are not allowed to modify / redistribute things that do not have an explicit license allowing us to do these modifications / redistributions. |
|
@nim65s iit-centauro-ros-pkg is now licensed under the Apache-2.0 license |
nim65s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the license !
We now just need to fix the paths to get green CI and this is good for me
The new centauro_description weights 9.3 MB total, all meshes are below 0.3MB.