Skip to content

Conversation

@AndrePatri
Copy link
Contributor

The new centauro_description weights 9.3 MB total, all meshes are below 0.3MB.

Copy link
Member

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for this contribution :)

Please add robots/centauro_description/README.md with a source for these files and their license.
And also a unit test.

Copy link
Collaborator

@cmastalli cmastalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AndrePatri!

It would be nice to include colour information.

@AndrePatri
Copy link
Contributor Author

@cmastalli, @nim65s, I've added the README.md following the scheme of the other robots and the unit test for nq and nv. As for what concerns the licence, currently the original repo from which I made my fork has no license file, even if it's public. So for now I've put no license. I'll ask people in my research line to add one. As for the colors, I'll try to do it, but I can't guarantee it will happen soon.

@cmastalli
Copy link
Collaborator

I am happy to proceed merging this PR without the colour changes.

We can always fix them later.

@nim65s
Copy link
Member

nim65s commented Dec 3, 2025

I'm afraid we are not allowed to modify / redistribute things that do not have an explicit license allowing us to do these modifications / redistributions.
At least here, in France, any work provided without a license must be considered as closed-source and can not be used in any way.
So if you want us to merge this, please contact the upstream authors to fix that TODO in their repo first, and then don't hesitate to re-open this PR.

@nim65s nim65s closed this Dec 3, 2025
@AndrePatri
Copy link
Contributor Author

@nim65s iit-centauro-ros-pkg is now licensed under the Apache-2.0 license

@nim65s nim65s reopened this Dec 4, 2025
Copy link
Member

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the license !
We now just need to fix the paths to get green CI and this is good for me

@nim65s nim65s merged commit e760b02 into Gepetto:devel Dec 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants