Skip to content

Fix geometry deduplication in LOD child tiles #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bertt merged 4 commits into from
Feb 5, 2026
Merged

Fix geometry deduplication in LOD child tiles #248

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea33e06
Initial plan
Copilot Feb 5, 2026
4ea012d
Pass processedGeometries to LOD child tiles to maintain deduplication
Copilot Feb 5, 2026
797ed34
Merge branch 'md5_implementation' into copilot/sub-pr-244-again
bertt Feb 5, 2026
48aa307
Update QuadtreeTiler.cs
bertt Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/b3dm.tileset/QuadtreeTiler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ private HashSet<string> CreateTileForLargestGeometries(BoundingBox bbox, Tile ti
var outputPath = $"{outputFolder}{Path.AltDirectorySeparatorChar}{file}";
TileCreationHelper.WriteTileIfNeeded(geometriesToProcess, translation, stylingSettings, copyright, createGltf, skipCreateTiles, outputPath, file);

ProcessLodLevels(bbox, tile, lod, createGltf, keepProjection);
ProcessLodLevels(bbox, tile, lod, createGltf, keepProjection, localProcessedGeometries);
if (!useImplicitTiling) {
UpdateTileBoundingBox(tile, tileHashes, where, keepProjection);
}
Expand Down Expand Up @@ -174,7 +174,7 @@ private void CreateTile(BoundingBox bbox, Tile tile, List<Tile> tiles, string wh
var outputPath = $"{outputFolder}{Path.AltDirectorySeparatorChar}{file}";
TileCreationHelper.WriteTileIfNeeded(geometries, translation, stylingSettings, copyright, createGltf, skipCreateTiles, outputPath, file);

ProcessLodLevels(bbox, tile, lod, createGltf, keepProjection);
ProcessLodLevels(bbox, tile, lod, createGltf, keepProjection, processedGeometries);
if (!useImplicitTiling) {
UpdateTileBoundingBox(tile, tileHashes, where, keepProjection);
}
Expand All @@ -187,7 +187,7 @@ private void CreateTile(BoundingBox bbox, Tile tile, List<Tile> tiles, string wh
tiles.Add(tile);
}

private void ProcessLodLevels(BoundingBox bbox, Tile tile, int lod, bool createGltf, bool keepProjection)
private void ProcessLodLevels(BoundingBox bbox, Tile tile, int lod, bool createGltf, bool keepProjection, HashSet<string> processedGeometries)
{
if (inputTable.LodColumn != String.Empty && lod < lods.Max()) {
// take the next lod
Expand All @@ -197,7 +197,7 @@ private void ProcessLodLevels(BoundingBox bbox, Tile tile, int lod, bool createG
// make a copy of the tile
var t2 = new Tile(tile.Z, tile.X, tile.Y);
t2.BoundingBox = tile.BoundingBox;
var lodNextTiles = GenerateTiles(bbox, t2, new List<Tile>(), nextLod, createGltf, keepProjection);
var lodNextTiles = GenerateTiles(bbox, t2, new List<Tile>(), nextLod, createGltf, keepProjection, processedGeometries);
tile.Children = lodNextTiles;
}
}
Expand Down
Loading