Fix geometry deduplication in LOD child tiles#248
Merged
bertt merged 4 commits intomd5_implementationfrom Feb 5, 2026
Merged
Conversation
Co-authored-by: bertt <538812+bertt@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on size-based geometry prioritization
Fix geometry deduplication in LOD child tiles
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ProcessLodLevelsmethod was callingGenerateTileswithout passing theprocessedGeometriesparameter, causing geometries already processed at parent LOD levels to be duplicated in child LOD tiles.Changes
ProcessLodLevelssignature to acceptHashSet<string> processedGeometriesparameterprocessedGeometriesthrough toGenerateTilescall for LOD childrenCreateTileForLargestGeometriesandCreateTile) to pass their respective processed geometry setsThis ensures the size-based geometry prioritization correctly deduplicates across all LOD levels.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.