Skip to content

gr25: add ecu pedals msg#84

Merged
BK1031 merged 2 commits intomainfrom
bk1031/gr25-ecu-ingest
Jun 7, 2025
Merged

gr25: add ecu pedals msg#84
BK1031 merged 2 commits intomainfrom
bk1031/gr25-ecu-ingest

Conversation

@BK1031
Copy link
Contributor

@BK1031 BK1031 commented Jun 7, 2025

No description provided.

@BK1031 BK1031 requested a review from Copilot June 7, 2025 02:12
@netlify
Copy link

netlify bot commented Jun 7, 2025

Deploy Preview for gr-mapache canceled.

Name Link
🔨 Latest commit 2b1fce5
🔍 Latest deploy log https://app.netlify.com/projects/gr-mapache/deploys/6843a34ab0b7200008864088

@BK1031 BK1031 enabled auto-merge June 7, 2025 02:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new ECU Pedals CAN message type, registering it in the message registry and defining its signal extraction logic.

  • Adds ECUPedals entry (ID 0x02E) to the global messageMap
  • Defines ECUPedals with four pedal-related fields and their conversion logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
gr25/model/message.go Registers ECUPedals (0x02E) in the message map
gr25/model/ecu.go Implements ECUPedals message and its signal parsing
Comments suppressed due to low confidence (2)

gr25/model/ecu.go:138

  • [nitpick] There’s no comment describing the purpose or units of the ECUPedals message or its fields. Adding a doc comment above this declaration will help future readers understand its intent.
var ECUPedals = mp.Message{

gr25/model/ecu.go:138

  • New message parsing logic for ECUPedals is introduced without corresponding tests. Please add unit tests to verify each field’s conversion and signal output.
var ECUPedals = mp.Message{

@BK1031 BK1031 disabled auto-merge June 7, 2025 02:23
Copy link
Contributor

@gauchoracing gauchoracing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passes mpbench!

@BK1031 BK1031 enabled auto-merge June 7, 2025 02:29
@BK1031 BK1031 merged commit aca88ba into main Jun 7, 2025
15 checks passed
@BK1031 BK1031 deleted the bk1031/gr25-ecu-ingest branch June 7, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants