Skip to content

Zarr Reading#197

Merged
SimarKareer merged 1 commit intomainfrom
aidan/zarr-reading
Feb 24, 2026
Merged

Zarr Reading#197
SimarKareer merged 1 commit intomainfrom
aidan/zarr-reading

Conversation

@aidang3019
Copy link
Contributor

@aidang3019 aidang3019 commented Feb 9, 2026

No description provided.

@aidang3019 aidang3019 marked this pull request as ready for review February 9, 2026 21:06
@aidang3019 Graphite App
Copy link
Contributor Author

aidang3019 commented Feb 9, 2026 •
edited by AnikethCheluva
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@aidang3019 aidang3019 mentioned this pull request Feb 9, 2026
Merged
SimarKareer
SimarKareer reviewed Feb 10, 2026
View reviewed changes
egomimic/rldb/zarr/action_chunk_transforms.py Outdated
# ---------------------------------------------------------------------------

class SingleArmEulerTransform(BaseActionChunkTransform):
"""Single-arm 6D (xyz + euler ypr) transform."""
Copy link
Collaborator

@SimarKareer SimarKareer Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearer docstring (input vs output_

egomimic/rldb/zarr/action_chunk_transforms.py
@@ -0,0 +1,194 @@
"""
Copy link
Collaborator

@SimarKareer SimarKareer Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run ruff on everything

egomimic/rldb/zarr/action_chunk_transforms.py Outdated
return self.transform_joints(actions, chunk_length)


class SingleArmEulerGripTransform(BaseActionChunkTransform):
Copy link
Collaborator

@SimarKareer SimarKareer Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transforms fixes
- zarr dataset should accept a list of transforms
- each transform's transform function should take just a keydict, then reference the classes init variables to see how to index into that keydict.
- Then zarrdataset itself shouldn't have imagekeys or actionkeys passed in

@aidang3019 aidang3019 force-pushed the aidan/zarr-reading branch 2 times, most recently from fd250c5 to 790eac4 Compare February 10, 2026 06:02
@aidang3019 aidang3019 mentioned this pull request Feb 10, 2026
Closed
@rl2aloha rl2aloha mentioned this pull request Feb 11, 2026
Open
@ElmoPA ElmoPA force-pushed the aidan/zarr-reading branch from 790eac4 to 907e5e1 Compare February 11, 2026 05:52
@RyanPCo RyanPCo mentioned this pull request Feb 12, 2026
Open
@ElmoPA ElmoPA force-pushed the aidan/zarr-reading branch from 4b4203d to 1847509 Compare February 12, 2026 05:22
@rl2aloha rl2aloha mentioned this pull request Feb 12, 2026
Merged
@ryanthecreator ryanthecreator mentioned this pull request Feb 13, 2026
Merged
@SimarKareer SimarKareer force-pushed the aidan/zarr-reading branch 3 times, most recently from 93d1ae8 to afa7e38 Compare February 17, 2026 05:09
@ElmoPA ElmoPA force-pushed the aidan/zarr-reading branch from d49bca3 to dca875e Compare February 19, 2026 19:31
@ElmoPA ElmoPA force-pushed the aidan/zarr-reading branch from ff2a588 to 1a34d79 Compare February 20, 2026 23:40
@aidang3019 aidang3019 mentioned this pull request Feb 21, 2026
Closed
@AnikethCheluva AnikethCheluva mentioned this pull request Feb 21, 2026
Closed
@aidang3019 aidang3019 mentioned this pull request Feb 22, 2026
Merged
@AnikethCheluva AnikethCheluva mentioned this pull request Feb 24, 2026
Merged
@SimarKareer SimarKareer mentioned this pull request Feb 24, 2026
Merged
@ryanthecreator ryanthecreator force-pushed the aidan/zarr-reading branch 2 times, most recently from 3903d93 to 4ec06ef Compare February 24, 2026 23:04
@SimarKareer Graphite App
Copy link
Collaborator

SimarKareer commented Feb 24, 2026 •
edited
Loading

Merge activity

  • Feb 24, 11:20 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 24, 11:21 PM UTC: @SimarKareer merged this pull request with Graphite.

@SimarKareer SimarKareer merged commit 91075ba into main Feb 24, 2026
1 check passed
@ryanthecreator ryanthecreator mentioned this pull request Feb 25, 2026
Merged
This was referenced Feb 27, 2026
Open
Draft
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimarKareer SimarKareer SimarKareer left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aidang3019 @SimarKareer