Closed
Conversation
SimarKareer
previously requested changes
Dec 16, 2025
egomimic/rldb/utils.py
Outdated
| item[key] = self._slow_down_sequence(item[key]) | ||
| return item | ||
|
|
||
| annotations = AnnotationLoader(root=self.root) |
Collaborator
There was a problem hiding this comment.
This should probably be loaded once, not every get_item call right?
egomimic/rldb/utils.py
Outdated
|
|
||
| if df_episode.empty: | ||
| logger.debug("No annotations for episode %s", ep_idx) | ||
| frame_item["lang_keys"] = None |
Collaborator
There was a problem hiding this comment.
like I was saying, it's not ideal to put a string into this dictionary. What do you think about tokenizing it before putting it into this dict?
|
|
||
| if __name__ == "__main__": | ||
|
|
||
| ano = AnnotationLoader( |
Collaborator
There was a problem hiding this comment.
Can you generate a video which overlays the text on screen, so we can confirm the annotation sync is correct?
AnikethCheluva
force-pushed
the
aniketh/annotation-loader
branch
2 times, most recently
from
364f6bd to
dd44ae8
Compare
AnikethCheluva
force-pushed
the
aniketh/annotation-loader
branch
4 times, most recently
from
8a14322 to
2ceb324
Compare
AnikethCheluva
force-pushed
the
aniketh/annotation-loader
branch
from
2ceb324 to
d3c98d3
Compare
AnikethCheluva
force-pushed
the
aniketh/annotation-loader
branch
from
d3c98d3 to
e9d9aad
Compare
AnikethCheluva
force-pushed
the
aniketh/annotation-loader
branch
from
e9d9aad to
dd2bc5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.