Skip to content

Fix/edit provider refresh redirect#344

Open
ND68 wants to merge 5 commits intodevelopfrom
fix/edit-provider-refresh-redirect
Open

Fix/edit provider refresh redirect#344
ND68 wants to merge 5 commits intodevelopfrom
fix/edit-provider-refresh-redirect

Conversation

@ND68
Copy link

@ND68 ND68 commented Mar 3, 2025

Fixed Issue #341 where refreshing on the edit page redirects to the add page and the selected provider is cleared.
Selected provider now persists on refresh when attempting to edit, and the edit page is still present on refresh.

@ND68 ND68 linked an issue Mar 3, 2025 that may be closed by this pull request
@thanasis457 thanasis457 self-requested a review March 4, 2025 22:10
@thanasis457
Copy link
Contributor

Your code is breaking existing functionality.
On the 'develop' branch, resizing the window persists the changes you have made to a provider before submitting. After your PR all the changes are gone upon resizing.
The same applies to your ticket. While a refresh now shows the provider data, any changes that were not submitted are lost.

Review your logic and re-request a review by me (@thanasis457)

@thanasis457 thanasis457 added the bug Something isn't working label Mar 4, 2025
@thanasis457
Copy link
Contributor

thanasis457 commented Mar 4, 2025

If it helps, one thing I noticed is that (in the 'develop' branch) if you make any change to a provider then both resizing and refreshing work as expected.

You might wanna look at what happens on a change and figure it out from there.

@ND68
Copy link
Author

ND68 commented Mar 4, 2025

I have a fix working now. Both refreshing and resizing will make the same data persist, even when edited.
Would having edited data persist upon refresh be a good idea?

@ND68
Copy link
Author

ND68 commented Mar 5, 2025

just fixed it. I tested it a bunch and didn't run into any of the data clearing issues anymore for both add and edit, but please let me know if you encounter one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PMT] Refresh Redirect

2 participants