Skip to content

[FIX] Fix compile errors for enum abstracts #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EliteMasterEric merged 1 commit into from
Jan 31, 2026
Merged

[FIX] Fix compile errors for enum abstracts #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions polymod/hscript/_internal/PolymodScriptClassMacro.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,6 @@ class PolymodScriptClassMacro {
for (field in abstractImplType.statics.get()) {
switch (field.kind) {
case FVar(read, write):
trace(field.name, read, write);

var canGet:Bool = read == AccInline || read == AccNormal;
if (read == AccCall) {
var getter:Null<ClassField> = null;
Expand Down Expand Up @@ -239,9 +237,20 @@ class PolymodScriptClassMacro {
pos: Context.currentPos(),
name: fieldName,
access: [Access.APublic, Access.AStatic],
kind: FProp(canGet ? 'get' : 'never', canSet ? 'set' : 'never', Context.toComplexType(field.type), null)
kind: FProp(canGet ? 'get' : 'never', canSet ? 'set' : 'never', (macro: Dynamic), null)
});

var fieldExpr:Expr = null;
try {
// when this fails, this should mean that we are dealing with an enum abstract
// so we need to handle it differently
var fullPath:String = '${abstractType.module}.${abstractType.name}';
Context.getType(fullPath);
fieldExpr = Context.parse('${fullPath}.${field.name}', Context.currentPos());
} catch (_) {
fieldExpr = Context.getTypedExpr(field.expr());
}

if (canGet) {
fields.push({
pos: Context.currentPos(),
Expand All @@ -252,7 +261,7 @@ class PolymodScriptClassMacro {
ret: null,
expr: macro {
@:privateAccess
return ${Context.parse(abstractPath + '.' + field.name, Context.currentPos())};
return ${fieldExpr};
}
})
});
Expand All @@ -268,7 +277,7 @@ class PolymodScriptClassMacro {
ret: null,
expr: macro {
@:privateAccess
return ${Context.parse(abstractPath + '.' + field.name, Context.currentPos())} = value;
return ${fieldExpr} = value;
}
})
});
Expand Down