[FIX] Fix compile errors for enum abstracts #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemz1
force-pushed
the
fix/fix-compile-errors
branch
from
dacc67a to
3b361f6
Compare
EliteMasterEric
force-pushed
the
experimental-abstracts
branch
from
031118e to
c49099f
Compare
AbnormalPoof
force-pushed
the
fix/fix-compile-errors
branch
from
658c563 to
69906dd
Compare
AbnormalPoof
force-pushed
the
fix/fix-compile-errors
branch
from
69906dd to
350e60c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we deal with an enum abstract we just get the field expression and parse it instead of trying to get the property using the type path.
Should help with one of the issues of #291
Note: Some abstracts cannot be resolved using Type.resolveClass, so we need to handle that too, currently it just throws an error. I assume most of them cannot be resolved because they are enum abstracts. However, there are few regular abstracts that cannot be resolved as well (Any, cpp.Callable, etc.)