Mask, Accumulator and some missing GraphBLAS ops #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
FlorentinD
changed the title
FlorentinD
force-pushed
the
mask_rebased
branch
3 times, most recently
from
fdce1ea to
bb082e4
Compare
FlorentinD
force-pushed
the
mask_rebased
branch
from
0c44c42 to
1b32102
Compare
added 22 commits
October 29, 2020 12:00
.. except StructualMasks as they dont need one + autogenerate Mask helper class for floats (reducing similar code)
…d for simple `mult()` .. need to combine cached prevResult and result at the end of the op (previous problem was that the computation overwrites the whole matrix structure -> thus also fields that were not even tried to be computed)
.. and correct default accumulator
.. before dimensions did not even match
(entry was still added in nz_rows) basically moved the mask check towards `multAddColA`
.. basically need the mask to correctly combine the results, as unneeded entries may still exists in the output (different to other ops)
.. off by one error again
added 7 commits
October 29, 2020 12:00
FlorentinD
force-pushed
the
mask_rebased
branch
from
9184a6d to
c1188a4
Compare
FlorentinD
force-pushed
the
mask_rebased
branch
from
c1188a4 to
70f7895
Compare
added 20 commits
November 2, 2020 09:26
Also rename a function to `addColA` (more correct than `multAddColA` there)
As version 0.40 was released in the mean-time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainly for visibility (at some point PR to main repo)