Masks #4
Closed
Masks #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. as proposed in GraphBLAS
.. and rename mult to times (as in graphblas)
.. fixing errors based on wrong identity element
* Updating functions to return output if null and use common input sanity check functions
.. only a simple test where one matrix is basically just a sparse vector
.. based on comments by @breandan
.. in order to support null as a result field, making it consistent with other ops
.. except StructualMasks as they dont need one + autogenerate Mask helper class for floats (reducing similar code)
…d for simple `mult()` .. need to combine cached prevResult and result at the end of the op (previous problem was that the computation overwrites the whole matrix structure -> thus also fields that were not even tried to be computed)
added 13 commits
August 6, 2020 13:25
.. and correct default accumulator
.. before dimensions did not even match
(entry was still added in nz_rows) basically moved the mask check towards `multAddColA`
.. basically need the mask to correctly combine the results, as unneeded entries may still exists in the output (different to other ops)
.. off by one error again
|
I’m looking to implement some GraphBLAS-like algos and, as I’m sure you’re aware, masks are effectively a requirement for that, so this would be great to see in EJML mainline. Awesome work, don’t stop! |
Owner
Author
|
I am implementing this as part of my master thesis, so I do not plan to stop ;) I also plan to add more algorithms in the next weeks like Pagerank. |
Owner
Author
|
replaced by #5 (needed to rebase the branch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on semi-ring PR (waiting to be accepted on main repo).
only on this fork for visibility