Open
Conversation
zeinaaabbb
force-pushed
the
implement-buildArgs-options
branch
from
822b7d4 to
3cff172
Compare
Member
apaleslimghost
left a comment
apaleslimghost
left a comment
There was a problem hiding this comment.
this is almost there! couple of small things to fix
zeinaaabbb
force-pushed
the
implement-buildArgs-options
branch
from
3cff172 to
b2c3944
Compare
zeinaaabbb
force-pushed
the
implement-buildArgs-options
branch
from
b2c3944 to
4232d83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPP-2691
Description
This PR implements the
buildArgsoption forDockerBuildtasks.buildArgsto the task options schemaGIT_COMMITbuild argbuildArgsin the docker plugin.toolkitrc.ymlChecklist:
feat(circleci): add support for nightly workflows,fix: set Heroku app name for staging apps too