Skip to content

Persona5: fixed missing nvngx_dlss.dll #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Filoppi merged 2 commits into from
Mar 6, 2026
Merged

Persona5: fixed missing nvngx_dlss.dll #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97e9c8a
Persona5: fixed missing nvngx_dlss.dll
kstuedem Feb 18, 2026
a1824c0
Persona5: improve compatibility with RenoDX texture upgrades
kstuedem Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build_and_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,8 @@ jobs:
-or $projectName -like '*Trine 5*' `
-or $projectName -like '*Just Cause 3*' `
-or $projectName -like '*Unreal Engine' `
-or $projectName -like '*Granblue Fantasy Relink*') {
-or $projectName -like '*Granblue Fantasy Relink*' `
-or $projectName -like '*Persona 5*') {
# Source path for NGX DLSS DLL

if (("${{ matrix.config }}" -eq "Development-Debug") -or ("${{ matrix.config }}" -eq "Development-Release")) {
Expand Down
31 changes: 16 additions & 15 deletions Source/Games/Persona 5/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
#define GAME_PERSONA_5 1

Check warning on line 1 in Source/Games/Persona 5/main.cpp

View workflow job for this annotation

GitHub Actions / Run linter

Source/Games/Persona 5/main.cpp:1:9 [cppcoreguidelines-macro-usage] 

macro 'GAME_PERSONA_5' used to declare a constant; consider using a 'constexpr' constant

Check warning on line 1 in Source/Games/Persona 5/main.cpp

View workflow job for this annotation

GitHub Actions / Run linter

Source/Games/Persona 5/main.cpp:1:9 [cppcoreguidelines-macro-to-enum] 

macro 'GAME_PERSONA_5' defines an integral constant; prefer an enum instead

Check warning on line 1 in Source/Games/Persona 5/main.cpp

View workflow job for this annotation

GitHub Actions / Run linter

Source/Games/Persona 5/main.cpp:1:1 [cppcoreguidelines-macro-to-enum] 

replace macro with enum

#define ALLOW_SHADERS_DUMPING 0

Check warning on line 3 in Source/Games/Persona 5/main.cpp

View workflow job for this annotation

GitHub Actions / Run linter

Source/Games/Persona 5/main.cpp:3:9 [cppcoreguidelines-macro-usage] 

macro 'ALLOW_SHADERS_DUMPING' used to declare a constant; consider using a 'constexpr' constant

Check warning on line 3 in Source/Games/Persona 5/main.cpp

View workflow job for this annotation

GitHub Actions / Run linter

Source/Games/Persona 5/main.cpp:3:9 [cppcoreguidelines-macro-to-enum] 

macro 'ALLOW_SHADERS_DUMPING' defines an integral constant; prefer an enum instead

Check warning on line 3 in Source/Games/Persona 5/main.cpp

View workflow job for this annotation

GitHub Actions / Run linter

Source/Games/Persona 5/main.cpp:3:1 [cppcoreguidelines-macro-to-enum] 

replace macro with enum
#define DISABLE_DISPLAY_COMPOSITION 1

Check warning on line 4 in Source/Games/Persona 5/main.cpp

View workflow job for this annotation

GitHub Actions / Run linter

Source/Games/Persona 5/main.cpp:4:9 [cppcoreguidelines-macro-usage] 

macro 'DISABLE_DISPLAY_COMPOSITION' used to declare a constant; consider using a 'constexpr' constant

Check warning on line 4 in Source/Games/Persona 5/main.cpp

View workflow job for this annotation

GitHub Actions / Run linter

Source/Games/Persona 5/main.cpp:4:9 [cppcoreguidelines-macro-to-enum] 

macro 'DISABLE_DISPLAY_COMPOSITION' defines an integral constant; prefer an enum instead
#define ENABLE_NGX 1

Check warning on line 5 in Source/Games/Persona 5/main.cpp

View workflow job for this annotation

GitHub Actions / Run linter

Source/Games/Persona 5/main.cpp:5:9 [cppcoreguidelines-macro-usage] 

macro 'ENABLE_NGX' used to declare a constant; consider using a 'constexpr' constant

Check warning on line 5 in Source/Games/Persona 5/main.cpp

View workflow job for this annotation

GitHub Actions / Run linter

Source/Games/Persona 5/main.cpp:5:9 [cppcoreguidelines-macro-to-enum] 

macro 'ENABLE_NGX' defines an integral constant; prefer an enum instead
#define ENABLE_FIDELITY_SK 1

#include "..\..\Core\core.hpp"

Check failure on line 8 in Source/Games/Persona 5/main.cpp

View workflow job for this annotation

GitHub Actions / Run linter

Source/Games/Persona 5/main.cpp:8:10 [clang-diagnostic-error] 

'..\..\Core\core.hpp' file not found

enum class FramePhase
{
Expand Down Expand Up @@ -499,7 +499,7 @@
auto CheckAndHandleRenderPassTransition = [native_device_context, &cmd_list_data, &device_data, &game_device_data](ID3D11RenderTargetView** render_target_views, ID3D11DepthStencilView* depth_stencil_view)
{
com_ptr<ID3D11Resource> resource;
render_target_views[0]->GetResource(&resource);
render_target_views[1]->GetResource(&resource);
if (!resource)
{
return DrawOrDispatchOverrideType::None;
Expand All @@ -513,9 +513,10 @@
D3D11_TEXTURE2D_DESC tex_desc;
tex->GetDesc(&tex_desc);

// the normal gbuffer is DXGI_FORMAT_R11G11B10_FLOAT
// for planar reflection it will be the standart scene color format(DXGI_FORMAT_R10G10B10A2_UNORM)
if (tex_desc.Format != DXGI_FORMAT_R11G11B10_FLOAT)
// the normal gbuffer is DXGI_FORMAT_R10G10B10A2_UNORM (or DXGI_FORMAT_R16G16B16A16_FLOAT when upgraded by renodx)
// for planar reflections render target 1 is DXGI_FORMAT_R8G8B8A8_UNORM
if (tex_desc.Format != DXGI_FORMAT_R10G10B10A2_UNORM &&
tex_desc.Format != DXGI_FORMAT_R16G16B16A16_FLOAT)
{
game_device_data.frame_phase = FramePhase::REFLECTION;
}
Expand Down Expand Up @@ -892,17 +893,17 @@

com_ptr<ID3D11ShaderResourceView> motion_vectors_srv;
{
D3D11_SHADER_RESOURCE_VIEW_DESC srv_desc;
srv_desc.Format = motion_vectors_desc.Format;
srv_desc.ViewDimension = D3D11_SRV_DIMENSION_TEXTURE2D;
srv_desc.Texture2D.MostDetailedMip = 0;
srv_desc.Texture2D.MipLevels = 1;
device->CreateShaderResourceView(game_device_data.motion_vectors.get(),
&srv_desc,
&motion_vectors_srv);
D3D11_SHADER_RESOURCE_VIEW_DESC srv_desc;
srv_desc.Format = motion_vectors_desc.Format;
srv_desc.ViewDimension = D3D11_SRV_DIMENSION_TEXTURE2D;
srv_desc.Texture2D.MostDetailedMip = 0;
srv_desc.Texture2D.MipLevels = 1;
device->CreateShaderResourceView(game_device_data.motion_vectors.get(),
&srv_desc,
&motion_vectors_srv);
}

ID3D11ShaderResourceView* srvs[] = { motion_vectors_srv.get()};
ID3D11ShaderResourceView* srvs[] = {motion_vectors_srv.get()};
ID3D11UnorderedAccessView* uavs[] = {game_device_data.decoded_motion_vectors_uav.get()};
native_device_context->CSSetShader(device_data.native_compute_shaders[CompileTimeStringHash("Decode Motion Vector")].get(), 0, 0);
native_device_context->CSSetShaderResources(0, 1, srvs);
Expand Down Expand Up @@ -1089,7 +1090,7 @@
}
if (ImGui::IsItemHovered(ImGuiHoveredFlags_AllowWhenDisabled))
{
ImGui::SetTooltip("When enabled setting Rendering Scale to 50%% or 75%% will use Super Resolution (DLSS or FSR) to scale the image to the output resolution.\nOtherwise Super Resolution will only be used as AA and the image is bilinearly upscaled.");
ImGui::SetTooltip("When enabled setting Rendering Scale to 50%% or 75%% will use Super Resolution (DLSS or FSR) to scale the image to the output resolution.\nOtherwise Super Resolution will only be used as AA and the image is bilinearly upscaled.");
}

const char* previewString;
Expand Down Expand Up @@ -1129,7 +1130,7 @@
}
if (ImGui::IsItemHovered(ImGuiHoveredFlags_AllowWhenDisabled))
{
ImGui::SetTooltip("Set ingame Shadow Quality to Medium. Requires restart/resetting Shadow Quality in settings.\nIn game settings:\nLow - 1024\nMedium - 2048\nHigh - 4096");
ImGui::SetTooltip("Set ingame Shadow Quality to Medium. Requires restart/resetting Shadow Quality in settings.\nIn game settings:\nLow - 1024\nMedium - 2048\nHigh - 4096");
}
}

Expand Down
Loading