Implement SwerveImu for threadedGyro #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ThreadedGyro when constructing subsystem in REAL mode
MikeKantrowitz
approved these changes
Jan 25, 2026
MikeKantrowitz
left a comment
MikeKantrowitz
left a comment
There was a problem hiding this comment.
Lots of changes. I don't understand everything here but I don't see anything obviously wrong :-) I assume this has been tested?
Contributor
Author
|
Thanks for the review @MikeKantrowitz , this has not been tested yet - I created the PR so that BatChen can see the changes and get ahead on what it does. I plan to test this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement SwerveImu for threadedGyro, replace JSON configuration with ThreadedGyro when constructing subsystem in REAL mode