Trivial changes after running Linter tool.

[Martinski4GitHub]

Just some trivial changes to remove a handful of new "warnings" from the latest Linter tool report.

[Martinski4GitHub]

@ExtremeFiretop,
I've added a 2nd commit to this PR, which is a new function that checks if the Gnuton F/W built-in 'webs_update.sh' script is the most recent version that includes the required fixes. If not, we set up a local version from our own repository.

There are 2 more steps to do if we decide to go for this temporary hack:

1. Add the following variable near the top of the Gnuton version of the 'webs_update.sh' script:

readonly SCRIPT_VERSTAG="25070312"

This variable will indicate that the 'webs_update.sh' script version has the latest required fixes (at least until now).

2. Copy a version of the fixed 'webs_update.sh' script to the MerlinAU repository under the name "gnuton_webs_update.sh" that will be downloaded and installed locally if and when needed.

That's it. Essentially, we're trying to make sure that at least one good copy of the script is found on the Gnuton F/W.

Let me know what you think. Again, this would be only a temporary workaround until the fixed script is installed in the next Gnuton F/W update build.

[ExtremeFiretop]

@Martinski4GitHub

Sorry for the delay, I went out to the local race track with some buddies yesterday and didn't come back until 11:30PM and was too tired to look into this then.

I've reviewed the code now and added a working file to our repo as requested under the dev branch! :)

[ExtremeFiretop]

Tested and seems to work now as expected! :)

[Martinski4GitHub]

@Martinski4GitHub

Sorry for the delay, I went out to the local race track with some buddies yesterday and didn't come back until 11:30PM and was too tired to look into this then.

Ah, no worries. I just came from a family barbecue on the account of being July 4th (a 3-day weekend!!! :>)😉

I've reviewed the code now and added a working file to our repo as requested under the dev branch! :)

👍

[Martinski4GitHub]

Tested and seems to work now as expected! :)

Looking good. BTW, the "SCRIPT_VERSTAG=" variable should be defined in the original script file as well when stored in Gnuton's repo. This way, if the "fixed" script is installed in the next Gnuton F/W update, the temporary workaround in MerlinAU will find it and will not install the local copy from our own repository.

IOW, the key is that if the variable definition is not found in the original built-in script file installed by the latest F/W update, MerlinAU will install its own local copy; otherwise, we're good to go, and the check function will install nothing.

Have a good night, bud!! Talk to you tomorrow evening. I'm going to bed right now myself.

[ExtremeFiretop]

Tested and seems to work now as expected! :)

Looking good. BTW, the "SCRIPT_VERSTAG=" variable should be defined in the original script file as well when stored in Gnuton's repo. This way, if the "fixed" script is installed in the next Gnuton F/W update, the temporary workaround in MerlinAU will find it and will not install the local copy from our own repository.

IOW, the key is that if the variable definition is not found in the original built-in script file installed by the latest F/W update, MerlinAU will install its own local copy; otherwise, we're good to go, and the check function will install nothing.

Have a good night, bud!! Talk to you tomorrow evening. I'm going to bed right now myself.

I can add it to the original as well, I'll just have to add a note why it exists for Gnuton