-
Notifications
You must be signed in to change notification settings - Fork 2
Dev 1.5.0 as Next Stable Release #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reverse Sync Back Into Dev
Fix "Offline" Version Detection for Gnuton
Patch Gnuton Version Detection
- Modified function "_GetRequiredRAM_KB_()" to take either a "URL=" parameter or a "FPATH=" parameter which indicates how to get the require file size (remotely or locally). - Minor code improvements.
Modifications and Improvements
Implemented the new changes for _GetRequiredRAM_KB_ into the offline mode for Gntuon and Merlin firmware
Added Missing Date Changes
Make Offline Mode True Offline
Just some trivial changes to remove a handful of new "warnings" from the latest Linter tool report.
Added a TEMPORARY hack to check if the Gnuton F/W built-in 'webs_update.sh' script is the most recent version that includes required fixes. If not, we temporarily set up a local version so that MerlinAU can continue to work by detecting available F/W version updates.
Trivial changes after running Linter tool.
Martinski4GitHub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and good to go live!!
|
BTW, have you received any feedback/reply from Gnuton about the issues, fixes, and possible solution WRT the ' I'm wondering if he'd be receptive to the name change proposed by RMerlin, which would match our own copy in MerlinAU's repo. In the meantime, at least we already have a "workaround" in our back pocket that allows MerlinAU to continue working with Gnuton F/W update checks as expected. P.S. |
No words yet. Just checked the PR and discord to be sure and nothing yet. I hope he is, but I wasn't going to wait for a reply to send out the fix unless he happened to speak up while we were working on it. If we happen to be faster than so be it ;)
Exactly; if we need to tweak it again down the line so be it, but according to RMerlin it should be a change done at build time so unlikely we should need to change anything with this solution we just pushed out. Would of been nice to confirm the game plan with him first but we can move quickly haha!
No worries, sorry for the delay, my girlfriend and I were planning our vacation this year, just booked our all inclusive in Cancun Mexico, because she works in the hotel industry for the IHG chain of hotels, we got the whole week for 830 USD at an Iberostar resort, which I think is a steal, the plane tickets were more expensive than the week trip at an all inclusive resort. Anyways all to say we are very excited but were busy finding and finalizing those last minute numbers, deals, times, etc. |
Yeah, it would be nice to get some confirmation or acknowledgment from Gnuton, but as you said, we couldn't really wait indefinitely, and since we can address the issue faster on our end, we might as well issue the release now rather than later while waiting for a reply.
Nice!! We've never been to Cancun, but I've heard from some friends & colleagues that it's a beautiful place. The only thing that several people have mentioned is that it tends to be very crowded during peak periods of the Summer months. So if you don't mind crowds and long waits at some tourist places, you'll be fine; otherwise, be prepared to deal with and navigate around large crowds. Anyway, I wish you both a great & relaxing vacation. Remember to brush up a little on your Spanish. It helps with the natives, and they seem to appreciate it when you try to speak it. Buen Viaje y Buena Suerte!!! 😉 👍 |
We booked it at the slow season (start of November) for exactly that reason!
We even picked a flight with a stop along the way instead of the direct flights because it was cheaper. (Only 1 stop in Toronto, for 55 minutes and then the final flight to Cancun) basically extends the daily travel time an extra hour but saving that extra hour wasn't worth the cost they wanted for the direct flight lol. Between her points from her work and the cheap budgeting we got the whole trip with stay and flights for about 2700 CAD (1900 USD?) at a 4.5/5 star resort. Absolute steal I'd say. We obviously will probably spend on checking out some sights around like the Mayan ruins and some travel too and from the airport but outside of that I hope we keep things within budget at an all inclusive this year. Luckily Spanish is somewhat similar to French? Haha just gotta study up in the next 4 months! |
Excellent call. From what I understand, and based on our experience after vacationing on 2 separate trips to Cabo San Lucas (in the Baja California Peninsula), the "slow" season starts around mid-September until November, before the Christmas season, which is another peak time due to the "snowbirds" traveling from the north during Winter, LOL!!!
Yeah, looks like you got a good bargain!!! That's why it's good to plan and book everything months in advance so you can find those nice, all-inclusive vacation packages.
Yeah, they have many similar words, especially those with Latin and Greek roots, and the grammar is fairly similar (if you speak French slowly, even I can pick up a few phrases here and there). |
Who you calling a snowbird?!? 😉 Hahaha! I'm just kidding. My parents booked for February already, they are your classic snowbirds. In our case we won't have snow sticking to the ground yet in early November but the weather will be switching to the cold days with occasional snow falls. And that's good enough for us to leave haha 😂 don't even need to wait for the snow, just need to extend our summer a bit longer hehe 😁 |
LOL!!! You guys are traveling south "too early" to be called "snowbirds." 😉😆
I hear you, bud. For traveling to warmer, tropical climates, any reason is a good reason, in my book. |
Forms post update = READY
Readme update = COMPLETED
Version.txt update = COMPLETED
Dev 1.5.0 as Next Stable Release
What's Changed/Fixed?:
PR: [ #492 ] - Improved Gnuton Version Detection
PR: [ #493 ] - Modifications and Improvements
PR: [ #494 ] - Modify Trivial changes to Logic
PR: [ #495 ] - Trivial changes after running Linter tool.
As always, we highly recommend you update ASAP as this includes functional improvements and little bug fixes.
Thanks!