-
Notifications
You must be signed in to change notification settings - Fork 2
Modify Offline Flow #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Offline Flow #494
Conversation
Implemented the new changes for _GetRequiredRAM_KB_ into the offline mode for Gntuon and Merlin firmware
Added Missing Date Changes
|
Things done in this PR:
Now the offline mode is truly offline, and the require memory calculations are still working as expected as found below: |
|
This is what I should of initially done, but you know me, I go with the quickest and easiest fix that addresses the problem head on. It's why I dived into the deeper logic on why offline mode wasn't actually offline in the first place. The truth is there is no real reason it couldn't be truly offline in offline mode. |
This is looking good. And you're right, the "Offline F/W Update" mode should really be completely "offline." |
This is a much "cleaner" implementation for the Offline F/W Update. As you said, it really should not need to go out and remotely retrieve information because, presumably, the user doing the "Offline Update" should know what he's doing and would provide the required file(s) locally to perform the update. It was a good call to review the workflow and come up with a better & cleaner solution. Good job, bud!! You need to get more good night's sleep :>) |
Martinski4GitHub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and good to go!!


Implemented the new changes for GetRequiredRAM_KB into the offline mode for Gntuon and Merlin firmware