Skip to content

Conversation

@ExtremeFiretop
Copy link
Owner

Implemented the new changes for GetRequiredRAM_KB into the offline mode for Gntuon and Merlin firmware

Implemented the new changes for _GetRequiredRAM_KB_  into the offline mode for Gntuon and Merlin firmware
@ExtremeFiretop ExtremeFiretop marked this pull request as ready for review July 1, 2025 01:05
Added Missing Date Changes
@ExtremeFiretop
Copy link
Owner Author

ExtremeFiretop commented Jul 1, 2025

@Martinski4GitHub

Things done in this PR:

  1. Restored the GetLatestFWUpdateVersionFromGitHub function to only work with production releases (no longer finds pre-releases, same as production now before my latest PR: Improved Gnuton Version Detection #492 )
  2. Implemented your changed GetRequiredRAM_KB function in the offline mode
  3. Finally; Modified the RunOfflineUpdateNow to remove the steps currently in production which still require a "online connection" to an external source

Now the offline mode is truly offline, and the require memory calculations are still working as expected as found below:

  • GNUTON OFFLINE:
    image

  • RMERLIN OFFLINE:
    image

@ExtremeFiretop
Copy link
Owner Author

This is what I should of initially done, but you know me, I go with the quickest and easiest fix that addresses the problem head on.
But like I mentioned, after a good nights sleep I reflected and realized if I was a user of the offline mode, and I saw an error that it couldn't find the URL after I specifically uploaded the ZIP, i would be confused and it wouldn't make any sense.

It's why I dived into the deeper logic on why offline mode wasn't actually offline in the first place. The truth is there is no real reason it couldn't be truly offline in offline mode.

@Martinski4GitHub
Copy link
Collaborator

@Martinski4GitHub

Things done in this PR:

1. Restored the _GetLatestFWUpdateVersionFromGitHub_ function to only work with production releases (no longer finds pre-releases, same as production now before my latest PR: [Patch Gnuton Version Detection #492](https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/492) )

2. Implemented your changed _GetRequiredRAM_KB_ function in the offline mode

3. Finally; Modified the _RunOfflineUpdateNow_ to remove the steps currently in production which still require a "online connection" to an external source

Now the offline mode is truly offline, and the require memory calculations are still working as expected as found below:

* **GNUTON OFFLINE:**
  ![image](https://private-user-images.githubusercontent.com/1971404/460814699-7b06e18f-fcdd-4583-ba63-c5bb4d7170fd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTEzNTIxMzcsIm5iZiI6MTc1MTM1MTgzNywicGF0aCI6Ii8xOTcxNDA0LzQ2MDgxNDY5OS03YjA2ZTE4Zi1mY2RkLTQ1ODMtYmE2My1jNWJiNGQ3MTcwZmQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDcwMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTA3MDFUMDYzNzE3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTE5MGNmODc0MTcwMWFlMDc5M2E2OTI4OWM5NDUyYmE4ZTQ2NmUzODUyODcwZjMwMjdlNTBhOTdhOGJjYzcwNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.YsyOVckCWI009tbCYCOtx1TU4Lc1oDbFc2uWfc19k1w)

* **RMERLIN OFFLINE:**
  ![image](https://private-user-images.githubusercontent.com/1971404/460814786-53c6d4f1-7ed4-41d5-bb1f-1f6371da615f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTEzNTIxMzcsIm5iZiI6MTc1MTM1MTgzNywicGF0aCI6Ii8xOTcxNDA0LzQ2MDgxNDc4Ni01M2M2ZDRmMS03ZWQ0LTQxZDUtYmIxZi0xZjYzNzFkYTYxNWYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDcwMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTA3MDFUMDYzNzE3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjMzMGRmODRlMDA4ZTg4YjNhZmZiMmYzNjNiZmE3ODBjY2NkOThmMWVlYjg5MjgxZDAwODY4OGVhMjMzYjhhZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.fYYpN1Fe_3w7y6fO6I2XEqtm2hF87w3mGbnpDVgiwp0)

This is looking good. And you're right, the "Offline F/W Update" mode should really be completely "offline."

@Martinski4GitHub
Copy link
Collaborator

This is what I should of initially done, but you know me, I go with the quickest and easiest fix that addresses the problem head on. But like I mentioned, after a good nights sleep I reflected and realized if I was a user of the offline mode, and I saw an error that it couldn't find the URL after I specifically uploaded the ZIP, i would be confused and it wouldn't make any sense.

It's why I dived into the deeper logic on why offline mode wasn't actually offline in the first place. The truth is there is no real reason it couldn't be truly offline in offline mode.

This is a much "cleaner" implementation for the Offline F/W Update. As you said, it really should not need to go out and remotely retrieve information because, presumably, the user doing the "Offline Update" should know what he's doing and would provide the required file(s) locally to perform the update.

It was a good call to review the workflow and come up with a better & cleaner solution. Good job, bud!! You need to get more good night's sleep :>)

Copy link
Collaborator

@Martinski4GitHub Martinski4GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and good to go!!

@Martinski4GitHub Martinski4GitHub merged commit 289ed4c into dev Jul 1, 2025
1 check passed
@ExtremeFiretop ExtremeFiretop deleted the TruelyOffline branch July 5, 2025 00:16
@ExtremeFiretop ExtremeFiretop changed the title Make Offline Mode True Offline Modify Offline Flow Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants