fix: stop fabricating identical end datetime when no real end time exists#136
Merged
fix: stop fabricating identical end datetime when no real end time exists#136
Conversation
…ists Events without a real end time were getting their start datetime copied to _datamachine_event_end_datetime, causing '6:00 - 6:00 PM' display on 21k+ events (68% of all events). Root cause: meta-storage.php line 217 copied start → end when no endDate block attribute existed. Three inconsistent fallback strategies across meta-storage, MetaSyncAbilities, and CheckMetaSyncCommand made it worse. Changes: - meta-storage.php: delete end meta when no real end time (was: copy start) - DisplayVars: add safety guard for start == end time display - EventHydrator: skip end propagation for legacy start==end data - EventSchemaProvider: omit endDate from JSON-LD when it equals startDate - MetaSyncAbilities: unify dry-run preview with meta-storage logic - CheckMetaSyncCommand: unify CLI resync with meta-storage logic - Backfill: deleted 21,413 bogus end_datetime meta rows via SQL
Contributor
Homeboy Results —
|
This was referenced Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meta-storage.phpwas copying the start datetime to end datetime when no real end time was provided, causing 21k+ events (68% of all published events) to display as "6:00 - 6:00 PM"DisplayVars::format_time_range()now returns start time only when start == endmeta-storage.php,MetaSyncAbilities,CheckMetaSyncCommand) now use the same strategy: sentinel23:59:59for end-date-without-end-time, delete meta when no end data at allEventSchemaProvideromitsendDatefrom JSON-LD when it equalsstartDate(Google saysendDateis recommended not required, and identical values convey false precision)EventHydratorskips end propagation for legacy data where start == end_datamachine_event_end_datetimemeta rows where value equaled start datetimeBefore / After
"endDate": "2026-03-25T20:00:00"(same as start)endDateomitted