fix: calendar query and taxonomy counts use start_datetime as primary#137
Merged
fix: calendar query and taxonomy counts use start_datetime as primary#137
Conversation
EventQueryBuilder and Taxonomy_Helper were filtering exclusively by _datamachine_event_end_datetime, which most events no longer have after the end-datetime backfill. Events without end meta were invisible in the calendar, day groups, filter counts, and past/future toggle. Now uses _datamachine_event_datetime as primary with end_datetime as OR fallback for still-ongoing events. Pattern: upcoming = start >= now OR end >= now; past = start < now AND (end < now OR no end meta).
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #136 — the calendar query layer was still filtering exclusively by
_datamachine_event_end_datetime, making 21k+ events without end meta invisible._datamachine_event_datetimeas primary with_datamachine_event_end_datetimeOR fallbackPattern everywhere:
upcoming = start >= now OR end >= now,past = start < now AND (end < now OR no end meta)