Open
Conversation
aslanliafichev
force-pushed
the
MBP-359-add-soft-limits-mainvisu
branch
from
04ca56c to
a2f0228
Compare
szilard-ess
requested changes
Mar 30, 2026
Collaborator
szilard-ess
left a comment
szilard-ess
left a comment
There was a problem hiding this comment.
The main functionality works, but I noticed a couple of things while testing.
- The buttons input deactivates on GVL.astAxes[MAIN.hmiAxisSelection].stStatus.bGeared, which probably not inteded, as usually you want to deactivate motion commands.
- The display field should work similar to the position or velocity display, that you cant click inside and edit.
- There is one minor issue, the input field goes white if you enter a negative number. It is only an issue at the newly added input boxes. Older ones display negative numbers correctly. See picture below.
aslanliafichev
changed the title
Collaborator
Author
|
1. Remove GVL.astAxes[MAIN.hmiAxisSelection].stStatus.bGeared 2. Make the box non-editable for current soft limit. 3. Fix negative numbers.
aslanliafichev
force-pushed
the
MBP-359-add-soft-limits-mainvisu
branch
from
1ee62b8 to
55c9aa1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added soft limits to MainVisu, test if it works as intended.