Skip to content

[fix] Missing session validation in file download routes causes 500 Internal Error #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krrishrastogi05 wants to merge 1 commit into from
Closed

[fix] Missing session validation in file download routes causes 500 Internal Error #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions API/Routes/DataFile/DataFileRoute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,45 +172,69 @@ def downloadDataFile():
#path = "/Examples.pdf"
case = session.get('osycase', None)
caserunname = request.args.get('caserunname')

if not case or not caserunname:
return jsonify({'message': 'Missing session or parameters.', 'status_code': 'error'}), 400

dataFile = Path(Config.DATA_STORAGE,case, 'res',caserunname, 'data.txt')
return send_file(dataFile.resolve(), as_attachment=True, max_age=0)

except(IOError):
return jsonify('No existing cases!'), 404
except TypeError:
return jsonify({'message': 'Invalid path parameters.', 'status_code': 'error'}), 400

@datafile_api.route("/downloadFile", methods=['GET'])
def downloadFile():
try:
case = session.get('osycase', None)
file = request.args.get('file')

if not case or not file:
return jsonify({'message': 'Missing session or parameters.', 'status_code': 'error'}), 400

dataFile = Path(Config.DATA_STORAGE,case,'res','csv',file)
return send_file(dataFile.resolve(), as_attachment=True, max_age=0)

except(IOError):
return jsonify('No existing cases!'), 404
except TypeError:
return jsonify({'message': 'Invalid path parameters.', 'status_code': 'error'}), 400

@datafile_api.route("/downloadCSVFile", methods=['GET'])
def downloadCSVFile():
try:
case = session.get('osycase', None)
file = request.args.get('file')
caserunname = request.args.get('caserunname')

if not case or not file or not caserunname:
return jsonify({'message': 'Missing session or parameters.', 'status_code': 'error'}), 400

dataFile = Path(Config.DATA_STORAGE,case,'res',caserunname,'csv',file)
return send_file(dataFile.resolve(), as_attachment=True, max_age=0)

except(IOError):
return jsonify('No existing cases!'), 404
except TypeError:
return jsonify({'message': 'Invalid path parameters.', 'status_code': 'error'}), 400

@datafile_api.route("/downloadResultsFile", methods=['GET'])
def downloadResultsFile():
try:
case = session.get('osycase', None)
caserunname = request.args.get('caserunname')

if not case or not caserunname:
return jsonify({'message': 'Missing session or parameters.', 'status_code': 'error'}), 400

dataFile = Path(Config.DATA_STORAGE,case, 'res', caserunname,'results.txt')
return send_file(dataFile.resolve(), as_attachment=True, max_age=0)

except(IOError):
return jsonify('No existing cases!'), 404
except TypeError:
return jsonify({'message': 'Invalid path parameters.', 'status_code': 'error'}), 400

@datafile_api.route("/run", methods=['POST'])
def run():
Expand Down