[fix] Missing session validation in file download routes causes 500 Internal Error#239
Closed
krrishrastogi05 wants to merge 1 commit intoEAPD-DRB:mainfrom
Closed
Conversation
Collaborator
|
@krrishrastogi05 Thanks for the work here. I’m closing this in favor of #416, which we’re keeping as the current implementation PR for the missing-session download crash tracked under #240. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/downloadFile,/downloadCSVFile, and/downloadResultsFileinDataFileRoute.py. Added explicit catch blocks forTypeError. (Note:downloadDataFilewas left untouched to preserve existing commented code/structure).TypeErrorexceptions from crashing the server. Previously, ifsession.get('osycase')wasNone, passing it topathlib.Pathbypassed theIOErrorcatch block, resulting in a 500 Internal Server Error.Related issues
Validation
/downloadFilewithout an active session -> Verified it returns a safe 400 error.Documentation
Scope check
OSeMOSYS/MUIOdependencyEAPD-DRB/MUIOGO:main(not upstream)