Skip to content

Fix PGP Signature change warning #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethwv merged 2 commits into from
Mar 22, 2026
Merged

Fix PGP Signature change warning #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18f4586
Add public key change detection
sethwv Mar 22, 2026
fd7c412
Update report script to clarify regeneration of embedded signatures i…
sethwv Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/scripts/validate/detect-changes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,17 @@ if [[ -z "$PLUGIN_LIST" ]]; then
fi
if [[ "$(has_write_access "$PR_AUTHOR")" -eq 1 ]]; then
# Repo maintainer with no plugin changes - skip plugin validation entirely and pass
PUB_KEY_CHANGED=false
if echo "$OUTSIDE_CHANGES" | grep -q "^\.github/scripts/keys/dispatcharr-plugins\.pub$"; then
PUB_KEY_CHANGED=true
fi
echo "matrix=[]" >> "$GITHUB_OUTPUT"
echo "plugin_count=0" >> "$GITHUB_OUTPUT"
echo "close_pr=false" >> "$GITHUB_OUTPUT"
echo "close_reason=" >> "$GITHUB_OUTPUT"
echo "skip_validation=true" >> "$GITHUB_OUTPUT"
echo "outside_violation=false" >> "$GITHUB_OUTPUT"
echo "pub_key_changed=$PUB_KEY_CHANGED" >> "$GITHUB_OUTPUT"
echo "No plugin changes detected - skipping plugin validation (author has write access)."
exit 0
fi
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/validate/report.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ done
echo "**Before merging, confirm:**"
echo "- The corresponding private key and passphrase secrets (\`GPG_PRIVATE_KEY\`, \`GPG_PASSPHRASE\`) have been updated in the repository settings."
echo "- The new public key has been bundled into the Dispatcharr application."
echo "- Existing \`.sig\` files on the \`releases\` branch will be regenerated on next publish."
echo "- Existing embedded signatures in \`manifest.json\` files on the \`releases\` branch will be regenerated on next publish."
echo ""
fi

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate-plugin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ jobs:
# --------------------------------------------------------------------------
report:
needs: [detect-changes, validate-plugin, codeql-analyze]
if: always() && needs.detect-changes.result == 'success' && needs.detect-changes.outputs.close_pr == 'false' && needs.detect-changes.outputs.skip_validation != 'true'
if: always() && needs.detect-changes.result == 'success' && needs.detect-changes.outputs.close_pr == 'false' && (needs.detect-changes.outputs.skip_validation != 'true' || needs.detect-changes.outputs.pub_key_changed == 'true')
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
Expand Down
Loading