Fix PGP Signature change warning#10
Merged
sethwv merged 2 commits intoDispatcharr:mainfrom Mar 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the validation workflow for plugin changes, with a particular focus on handling updates to the public key used for plugin signature verification. The main improvements ensure that changes to the public key are properly detected and that the reporting step is always run when the key changes, regardless of whether plugin validation is skipped.
Key workflow and script changes:
Public key change detection and reporting:
detect-changes.shscript now checks if the public key file (.github/scripts/keys/dispatcharr-plugins.pub) has changed, and sets a new output variablepub_key_changedaccordingly.reportjob in.github/workflows/validate-plugin.ymlis updated to always run the report step if the public key has changed, even if plugin validation is skipped.Reporting improvements:
manifest.jsonfiles (rather than just.sigfiles) will be regenerated on the next publish, reflecting the actual files affected by a key change.