Skip to content

Read mirror config via the config server #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DominicOram merged 3 commits into from
Dec 19, 2025
Merged

Read mirror config via the config server #1513

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c3f8b0
Read mirror config via the config server
jacob720 Dec 10, 2025
6050b4b
Merge branch 'main' into 1512_use_config_server_for_mirror_config
jacob720 Dec 16, 2025
3b54dfe
Merge branch 'main' into 1512_use_config_server_for_mirror_config
DominicOram Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/mx_bluesky/hyperion/device_setup_plans/dcm_pitch_roll_mirror_adjuster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import json

import bluesky.plan_stubs as bps
from dodal.devices.focusing_mirror import (
FocusingMirrorWithStripes,
Expand All @@ -17,6 +15,9 @@
from mx_bluesky.common.utils.utils import (
energy_to_bragg_angle,
)
from mx_bluesky.hyperion.external_interaction.config_server import (
get_hyperion_config_client,
)

MIRROR_VOLTAGE_GROUP = "MIRROR_VOLTAGE_GROUP"
DCM_GROUP = "DCM_GROUP"
Expand All @@ -27,11 +28,12 @@ def _apply_and_wait_for_voltages_to_settle(
stripe: MirrorStripe,
mirror_voltages: MirrorVoltages,
):
with open(mirror_voltages.voltage_lookup_table_path) as lut_file:
json_obj = json.load(lut_file)

config_server = get_hyperion_config_client()
config_dict = config_server.get_file_contents(
mirror_voltages.voltage_lookup_table_path, dict
)
# sample mode is the only mode supported
sample_data = json_obj["sample"]
sample_data = config_dict["sample"]
if stripe == MirrorStripe.BARE:
stripe_key = "bare"
elif stripe == MirrorStripe.RHODIUM:
Expand Down