Skip to content

Conversation

@jacob720
Copy link
Contributor

Fixes #1512

Instructions to reviewer on how to test:

  1. Check config is read through the config server

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@jacob720 jacob720 requested a review from a team as a code owner December 10, 2025 16:09
@jacob720 jacob720 added the dev experience Changes relating to developer experience label Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.29%. Comparing base (327c161) to head (3b54dfe).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1513   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         142      142           
  Lines        8094     8094           
=======================================
  Hits         7470     7470           
  Misses        624      624           
Components Coverage Δ
i24 SSX 78.56% <ø> (ø)
hyperion 97.93% <100.00%> (ø)
other 98.08% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@DominicOram DominicOram enabled auto-merge (squash) December 19, 2025 10:08
@DominicOram DominicOram merged commit 516aed9 into main Dec 19, 2025
16 checks passed
@DominicOram DominicOram deleted the 1512_use_config_server_for_mirror_config branch December 19, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Changes relating to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate mirror voltages config to daq-config-server

3 participants