Conversation
…ned the screens a bit
* status_controller -> scalar_controller - Contains all the scalar information to be read and configured * config_controller -> dtc_controller - Contains all the DTC configurations
GDYendell
left a comment
GDYendell
left a comment
There was a problem hiding this comment.
The tests need updating. In the introspection from the parameter tree dump, reduce the number of parameters expected in the root controller and then check the number in the scalar and dtc sub controllers too. Extend this test to validate the scalar and dtc controllers.
Could you make a PR to fastcs-odin for the group name change? I we can make a beta release to point this at so the CI works.
* Updated xspress.json input removing duplicated elements * Updated tests to check for sub-controllers * Updated test_xspress_parameter_creation to test_xspress_attribute_creation
* Capitalized adapter name * Added command to mock response to avoid errors
GDYendell
left a comment
GDYendell
left a comment
There was a problem hiding this comment.
I think we are ready to merge after these suggestions
|
I think before we merge we'll need to get FastCS-Odin and FastCS merged, right? Otherwise we'll be missing some features from both repos. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 91.83% 94.20% +2.36%
==========================================
Files 4 4
Lines 49 69 +20
==========================================
+ Hits 45 65 +20
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Added two new sub-controllers for DTC and Scalar parameters and group some of the parameters together.