Skip to content

Add option to override group in create_attribute#97

Merged
GDYendell merged 7 commits intomainfrom
add-group
Feb 20, 2026
Merged

Add option to override group in create_attribute#97
GDYendell merged 7 commits intomainfrom
add-group

Conversation

@LuisFSegalla
Copy link
Copy Markdown
Contributor

Add option to select custom group for attribute to be created under.

Based on this issue.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.83%. Comparing base (dee5e4d) to head (9acbfd4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files          16       16           
  Lines         614      614           
=======================================
  Hits          570      570           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LuisFSegalla LuisFSegalla marked this pull request as ready for review February 16, 2026 11:52
@GDYendell
Copy link
Copy Markdown
Contributor

GDYendell commented Feb 18, 2026

Could you add a test for create_attribute in test_util? I think it can be a parameterized test like this.

It should pass different arguments and check the type / fields on the returned attribute.

I am imagining these are the parameterizations (?):

  • OdinParameterMetadata(value=0, type="int", writeable=False) -> AttrR
  • OdinParameterMetadata(value=0, type="int", writeable=True) -> AttrRW
  • OdinParameterMetadata(value=0, type="int", writeable=False) and path=["name"] -> AttrRW(group=None)
  • OdinParameterMetadata(value=0, type="int", writeable=False) and path=["my_group", "name"] -> AttrRW(group="MyGroup")
  • OdinParameterMetadata(value=0, type="int", writeable=False) and group="MyOtherGroup" -> AttrRW(group="MyGroupOther")

* Initial version of the tests with parametrized values
@GDYendell GDYendell changed the title Add group Add option to override group in create_attribute Feb 20, 2026
@GDYendell GDYendell merged commit 8b4b2f1 into main Feb 20, 2026
9 checks passed
@GDYendell GDYendell deleted the add-group branch February 20, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants