Skip to content

Core: prevent crash when applying large flag sets #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
selfmusing wants to merge 1 commit into from
Closed

Core: prevent crash when applying large flag sets #1057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions app/src/main/java/de/dertyp7214/rboardthememanager/core/PorcessBuilder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,21 @@ package de.dertyp7214.rboardthememanager.core

import com.dertyp7214.logs.helpers.Logger
import java.io.File
import java.io.OutputStreamWriter

fun ProcessBuilder.su(vararg command: String): Process {
Logger.log(Logger.Companion.Type.INFO, "[ProcessBuilder.su]", command.joinToString(", "))
redirectError(File("/dev/null"))
command("su", "--mount-master", "-c", command.joinToString("; "))
return start()
}

// Start su without -c to avoid ARG_MAX overflow
command("su", "--mount-master")
val proc = start()

// Write commands through stdin instead of argv
OutputStreamWriter(proc.outputStream).use { w ->
command.forEach { w.appendLine(it) }
w.appendLine("exit")
}

return proc
}