Core: prevent crash when applying large flag sets#1057
Closed
selfmusing wants to merge 1 commit intoDerTyp7214:stagingfrom
Closed
Core: prevent crash when applying large flag sets#1057selfmusing wants to merge 1 commit intoDerTyp7214:stagingfrom
selfmusing wants to merge 1 commit intoDerTyp7214:stagingfrom
Conversation
Large flag/XML payloads caused "Argument list too long" when passed to `su -c`. Write commands via stdin instead of argv to prevent the crash.
Owner
|
Thanks for this pr, but staging is only for master -> staging merges. So please target master branch, then I will merge it. If you want you can also target the other branch for lower android versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large flag/XML payloads caused "Argument list too long" when passed to
su -c. Write commands via stdin instead of argv to prevent the crash.